Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reaper-reapack-extension: init at 1.2.5 #383221

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Conversation

pancaek
Copy link
Contributor

@pancaek pancaek commented Feb 19, 2025

Reapack is a package manager for REAPER. Discover, install, and keep up to date your REAPER resources including ReaScripts, JS effects, extensions, themes, language packs, templates, web interfaces and more.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pancaek pancaek marked this pull request as ready for review February 19, 2025 03:32
@pancaek pancaek marked this pull request as draft February 19, 2025 05:30
@pancaek pancaek force-pushed the reapack branch 6 times, most recently from dabd4a2 to 9c0f567 Compare February 19, 2025 06:32
@pancaek pancaek added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Feb 19, 2025
@pancaek pancaek force-pushed the reapack branch 7 times, most recently from 0021a62 to 945dcef Compare February 20, 2025 19:43
@pancaek
Copy link
Contributor Author

pancaek commented Feb 20, 2025

So far it seems like there's a linking issue on darwin, and I don't have a proper way to test it myself. I've gone ahead and split the derivation into two files so that it's easier to work on in the future. For now I've just made darwin grab the prebuilt files, so that I don't have to mark it broken.

@pancaek pancaek marked this pull request as ready for review February 20, 2025 21:30
@pancaek
Copy link
Contributor Author

pancaek commented Feb 21, 2025

I'm gonna poke at this some more, actually, back to drafts for a bit.
EDIT: nope

@pancaek pancaek marked this pull request as draft February 21, 2025 01:06
@pancaek pancaek force-pushed the reapack branch 2 times, most recently from 4f4d8d0 to 92e619a Compare February 21, 2025 01:57
@pancaek pancaek marked this pull request as ready for review February 21, 2025 02:11
@mksafavi
Copy link
Contributor

Nice 👍
I attempted packaging this but didn't get far :)

I built this pr and it works for me 👍
Is there anything needed to get this merged?

@pancaek
Copy link
Contributor Author

pancaek commented Mar 19, 2025

Just reviews/a committer, I'm glad it works for you! :)

@FliegendeWurst
Copy link
Member

Builds on x64 Linux. What kind of extensions does it manage? In particular, could native extensions need patching to run on NixOS?

@pancaek
Copy link
Contributor Author

pancaek commented Mar 19, 2025

It's not something I've ever come across, at least. Most of what's on reapack is built from reaper's own scripting/actions utilities, so I don't think we'll run into those sort of issues.

If they did arise somewhere one would just need to supply a forked repository inside of reapack to fix paths or whatnot for a given tool (but again, I don't think this should come up).

I also happen to know from poking through the reaper derivation that it already is set up to work with reapack itself, so barring some really strange interaction, we should be set.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 19, 2025
@FliegendeWurst FliegendeWurst merged commit 4316e6a into NixOS:master Mar 19, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants