Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdbook-pdf-outline: 0.1.4 -> 0.1.6 #383630

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

HollowMan6
Copy link
Member

@HollowMan6 HollowMan6 commented Feb 20, 2025

Define pname separately for mdbook-pdf-outline: mdbook_pdf_outline
due to PyPI tarball name change. Reference:

Change maintainer from nix-julia to hollowman6 as agreed.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 24, 2025
@HollowMan6 HollowMan6 force-pushed the mdbook-pdf-outline-update branch from f5137ed to 459a0ba Compare March 9, 2025 21:11
@HollowMan6 HollowMan6 changed the title mdbook-pdf-outline: 0.1.4 -> 0.1.5 mdbook-pdf-outline: 0.1.4 -> 0.1.6 Mar 9, 2025
@HollowMan6 HollowMan6 requested a review from nix-julia March 9, 2025 21:13
@HollowMan6 HollowMan6 force-pushed the mdbook-pdf-outline-update branch 2 times, most recently from 2c68fb7 to 25ee8d8 Compare March 9, 2025 21:18
@HollowMan6 HollowMan6 force-pushed the mdbook-pdf-outline-update branch 2 times, most recently from 5d4e34a to c8e9966 Compare March 10, 2025 14:01
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5273

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 11, 2025
@HollowMan6 HollowMan6 force-pushed the mdbook-pdf-outline-update branch from c8e9966 to d7ef4f4 Compare March 11, 2025 14:29
@HollowMan6 HollowMan6 requested a review from ShamrockLee March 11, 2025 14:33
Define `pname` separately for `mdbook-pdf-outline`: `mdbook_pdf_outline`
due to PyPI tarball name change. Reference:

- https://pypi.org/project/mdbook-pdf-outline/0.1.4/#files
- https://pypi.org/project/mdbook-pdf-outline/0.1.6/#files

Signed-off-by: Hollow Man <hollowman@opensuse.org>
from `nix-julia` to `hollowman6` as agreed

Signed-off-by: Hollow Man <hollowman@opensuse.org>
@HollowMan6 HollowMan6 force-pushed the mdbook-pdf-outline-update branch from d7ef4f4 to 2b35c4d Compare March 14, 2025 18:22
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Mar 16, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2311

@ShamrockLee ShamrockLee merged commit fda141b into NixOS:master Mar 19, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants