-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mdbook-pdf-outline: 0.1.4 -> 0.1.6 #383630
Merged
ShamrockLee
merged 2 commits into
NixOS:master
from
HollowMan6:mdbook-pdf-outline-update
Mar 19, 2025
Merged
mdbook-pdf-outline: 0.1.4 -> 0.1.6 #383630
ShamrockLee
merged 2 commits into
NixOS:master
from
HollowMan6:mdbook-pdf-outline-update
Mar 19, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nix-julia
approved these changes
Feb 23, 2025
f5137ed
to
459a0ba
Compare
2c68fb7
to
25ee8d8
Compare
nix-julia
reviewed
Mar 9, 2025
nix-julia
approved these changes
Mar 9, 2025
5d4e34a
to
c8e9966
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5273 |
ShamrockLee
requested changes
Mar 11, 2025
c8e9966
to
d7ef4f4
Compare
Define `pname` separately for `mdbook-pdf-outline`: `mdbook_pdf_outline` due to PyPI tarball name change. Reference: - https://pypi.org/project/mdbook-pdf-outline/0.1.4/#files - https://pypi.org/project/mdbook-pdf-outline/0.1.6/#files Signed-off-by: Hollow Man <hollowman@opensuse.org>
from `nix-julia` to `hollowman6` as agreed Signed-off-by: Hollow Man <hollowman@opensuse.org>
d7ef4f4
to
2b35c4d
Compare
nix-julia
approved these changes
Mar 16, 2025
ShamrockLee
approved these changes
Mar 16, 2025
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
12.approvals: 2
This PR was reviewed and approved by two reputable people
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define
pname
separately formdbook-pdf-outline
:mdbook_pdf_outline
due to PyPI tarball name change. Reference:
Change maintainer from
nix-julia
tohollowman6
as agreed.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.