Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-rebuild: fixed man page typo #383743

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

Andrew15-5
Copy link
Contributor

@Andrew15-5 Andrew15-5 commented Feb 20, 2025

I was RTFM and found --- CLI option which immediately caught my attention. After which I was surprised that in source you need to use one minus instead of two. And this is also the only place in the whole repo where rg '.Fl --' found a match.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 20, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 22, 2025
@SuperSandro2000 SuperSandro2000 changed the title docs(nixos-rebuild): fixed man page typo nixos-rebuild: fixed man page typo Mar 22, 2025
@SuperSandro2000
Copy link
Member

Please take a look at the contributing guide. We don't do semantic commits.

@SuperSandro2000 SuperSandro2000 merged commit e4417f0 into NixOS:master Mar 22, 2025
44 checks passed
@Andrew15-5 Andrew15-5 deleted the fix-nixos-rebuild-docs branch March 23, 2025 08:25
@Andrew15-5
Copy link
Contributor Author

Yeah, I'm not sure if I forgot or was it one of the first patches. I see the related section in pkgs/README.md.

But maybe I just looked that a bunch of other commits were structured like that, so I did the same. 128 commits: git log --oneline | rg '^\w+ (docs?|nix|nixos|feat|build|update|fix|tweak)\(.*?\):' (some of them are custom?).

andrew-field pushed a commit to andrew-field/alterware that referenced this pull request Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants