linux/common-config: Adjust some options unavailable on i686 #384588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timschumi
commented
Feb 23, 2025
github-actions
bot
added
10.rebuild-darwin: 0
|
ofborg or their workflow-y cousin do not seem to be able to recognize who is the maintainer for changes like this. To be perfectly honest, I am not able to do that either. Pinging some people that look related according to recent kernel changes, apologies in advance. |
K900
reviewed
Feb 24, 2025
K900
reviewed
Feb 24, 2025
timschumi
force-pushed
the
linux-6.12-i686
branch
from
8364244 to
d78bead
Compare
K900
reviewed
Mar 12, 2025
The ongoing RISC-V breakage may become version independent in the future, move it to the correct condition before updating it with the full list of supported architectures. While at it, simplify the remaining rustc-specific conditions into an `availableOn`.
timschumi
force-pushed
the
linux-6.12-i686
branch
3 times, most recently
from
a04ede0 to
bcd4842
Compare
This keeps us from accidentally running into platforms where Rust is not supported by the Linux kernel itself (for that particular platform).
The table with kernel version and compiler requirements only starts from Linux 6.12 now (the previous default), so update the force-enable logic to accommodate users that don't want to follow those suggestions. This includes printing warnings instead of asserting and allowing the force-enable to override both the compiler check and the version (or architecture) check.
BPF_JIT is not supported on i686, so we need to make sure that options that depend on BPF_JIT don't get enabled either.
timschumi
force-pushed
the
linux-6.12-i686
branch
from
bcd4842 to
d0d4a8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HID_BPF and SCHED_CLASS_EXT directly depend on BPF_JIT, so guard them with the same condition.
HAVE_RUST is explicitly only enabled for x86_64 in the x86 architecture configuration, so do not assume the kernel supports Rust when building for i686.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.