Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.11] network: make network setup service do not depend on udev, and fix typo with greTunnels #384965

Merged
merged 1 commit into from
Mar 18, 2025
Merged

[Backport release-24.11] network: make network setup service do not depend on udev, and fix typo with greTunnels #384965

merged 1 commit into from
Mar 18, 2025
+2 −1

Conversation

nixpkgs-ci[bot]
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Feb 25, 2025

Bot-based backport to release-24.11, triggered by a label in #373931.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@thomasfire @github-actions
network: make network-setup service do not depend on udevd directly; …
13bebbb 
…fix typo with GRE tunnels

Otherwise, when doing nixos switch to major changes (typically when stdenv changes), udevd service gets loaded after addresses, which causes addresses service to wait indefinitely for the device and fail.

Signed-off-by: Egor Savkin <es@m-labs.hk>
(cherry picked from commit 201f277)
@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Feb 25, 2025
Merged
19 tasks
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 25, 2025
rnhmjoj
rnhmjoj requested changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backport should wait until the PR reaches nixos-unstable and receive some more testing. I couldn't find any issue, but there may be unintended consequences with this change.

@wolfgangwalther
Copy link
Contributor

The backport should wait until the PR reaches nixos-unstable and receive some more testing. I couldn't find any issue, but there may be unintended consequences with this change.

3 weeks of testing enough @rnhmjoj?

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Mar 18, 2025

Thank you for reminding me. I guess it should be pretty safe, now.

@rnhmjoj rnhmjoj merged commit 6363dc0 into release-24.11 Mar 18, 2025
28 checks passed
@bjornfor bjornfor deleted the backport-373931-to-release-24.11 branch March 21, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wolfgangwalther @rnhmjoj @thomasfire