Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add COSMIC section #386400

Merged
merged 1 commit into from
Mar 18, 2025
Merged

doc: add COSMIC section #386400

merged 1 commit into from
Mar 18, 2025

Conversation

HeitorAugustoLN
Copy link
Member

@HeitorAugustoLN HeitorAugustoLN commented Mar 2, 2025

Adds a section for packaging COSMIC applications in the nixpkgs documentation

cc @a-kenji

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@a-kenji a-kenji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@HeitorAugustoLN HeitorAugustoLN added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 2, 2025
@HeitorAugustoLN HeitorAugustoLN mentioned this pull request Mar 2, 2025
13 tasks
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 17, 2025
@Mic92
Copy link
Member

Mic92 commented Mar 18, 2025

I believe this file needs to be added in languages-frameworks/index.md to be included in the manual.

@HeitorAugustoLN
Copy link
Member Author

I believe this file needs to be added in languages-frameworks/index.md to be included in the manual.

Didn't know about that, fixed it. Thanks!

@HeitorAugustoLN HeitorAugustoLN requested a review from a-kenji March 18, 2025 18:38
@HeitorAugustoLN HeitorAugustoLN force-pushed the docs/cosmic/init branch 3 times, most recently from 602e4bd to bb0e1d3 Compare March 18, 2025 18:48
@Mic92 Mic92 merged commit b75d47e into NixOS:master Mar 18, 2025
26 of 29 checks passed
@HeitorAugustoLN HeitorAugustoLN deleted the docs/cosmic/init branch March 18, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants