Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grocy: 4.3.0 -> 4.4.2 #387015

Merged
merged 2 commits into from
Mar 19, 2025
Merged

grocy: 4.3.0 -> 4.4.2 #387015

merged 2 commits into from
Mar 19, 2025

Conversation

tebriel
Copy link
Contributor

@tebriel tebriel commented Mar 4, 2025

Updated the patches to include more variables and shift line/chunk references for grocy 4.4.2

Builds off of #386436

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tebriel
Copy link
Contributor Author

tebriel commented Mar 4, 2025

I'm looking into why the grocy.passthru.tests are failing, I can replicate locally.

Tests should pass now.

Copy link
Contributor

@erplsf erplsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, thank you for picking it up and fixing it.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Mar 4, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 387015


x86_64-linux

✅ 1 package built:
  • grocy

aarch64-linux

✅ 1 package built:
  • grocy

x86_64-darwin

✅ 1 package built:
  • grocy

aarch64-darwin

✅ 1 package built:
  • grocy

@GaetanLepage GaetanLepage merged commit 871ff1d into NixOS:master Mar 19, 2025
52 checks passed
@tebriel tebriel deleted the grocy/4.4.2 branch March 19, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants