electron-{bin,source,chromedriver}_35: init at 35.0.3 #387294

teutat3s · 2025-03-05T13:42:32Z

https://github.com/electron/electron/releases/tag/v35.0.0
https://github.com/electron/electron/releases/tag/v35.0.1
https://github.com/electron/electron/releases/tag/v35.0.2
https://github.com/electron/electron/releases/tag/v35.0.3

Things done

Add a 👍 reaction to pull requests you find important.

emilylange · 2025-03-07T11:41:31Z

Coming from #387264, #387370 has been merged in the meantime and should allow for a relatively painless electron-source.electron_34 bring up, if you want. Just as a fyi.

teutat3s · 2025-03-08T15:46:45Z

Sigh. The source build needs some more work, converting to draft. Error message for the curious reader:

       > Running phase: buildPhase
       > ninja: Entering directory `out/Release'
       > [1/7] COPY ../../third_party/electron_node/deps/zlib/zconf.h gen/node_headers/include/node/zconf.h
       > [2/7] COPY ../../third_party/electron_node/deps/zlib/zlib.h gen/node_headers/include/node/zlib.h
       > [3/7] ACTION //electron:node_version_header(//build/toolchain/linux/unbundle:default)
       > [4/7] ACTION //electron:generate_config_gypi(//build/toolchain/linux/unbundle:default)
       > WARNING: --openssl-no-asm will result in binaries that do not take advantage
       >          of modern CPU cryptographic instructions and will therefore be slower.
       >          Please refer to BUILDING.md
       > WARNING: warnings were emitted in the configure phase
       > INFO: configure completed successfully
       > [5/7] COPY gen/config.gypi gen/node_headers/include/node/config.gypi
       > [6/7] COPY ../../third_party/electron_node/common.gypi gen/node_headers/include/node/common.gypi
       > [7/7] ACTION //electron:generate_node_headers(//build/toolchain/linux/unbundle:default)
       > FAILED: gen/node_headers.json
       > python3 ../../electron/script/node/generate_node_headers.py
       > Traceback (most recent call last):
       >   File "/build/src/out/Release/../../electron/script/node/generate_node_headers.py", line 68, in <module>
       >     options = install.parse_options([
       >               ^^^^^^^^^^^^^^^^^^^^^^^
       >   File "/build/src/third_party/electron_node/tools/install.py", line 419, in parse_options
       >     with open(options.config_gypi_path) as f:
       >          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       > FileNotFoundError: [Errno 2] No such file or directory: '/build/src/out/Testing/gen/config.gypi'

TomaSajt · 2025-03-08T15:54:54Z

I'm glad I put the header generation before the main build, this way we knew that it failed before building the entire browser.

teutat3s · 2025-03-08T16:11:42Z

Tracked down a bit to this commit electron/electron@7a5e961 / PR electron/electron#44657.

TomaSajt · 2025-03-08T16:37:51Z

This is the culprit:
https://github.com/electron/electron/blob/e4bd0cd3dcc57cb6889f845c75952bf999cbf581/script/node/generate_node_headers.py#L34-L39

The directory is not called "Testing" in release builds. They expect the ELECTRON_OUT_DIR do be set to "Release".

TomaSajt · 2025-03-08T17:31:22Z

This small change fixes it:

diff --git a/pkgs/development/tools/electron/common.nix b/pkgs/development/tools/electron/common.nix
index f0d84e9d2692..19777b11b584 100644
--- a/pkgs/development/tools/electron/common.nix
+++ b/pkgs/development/tools/electron/common.nix
@@ -64,6 +64,9 @@ in
     hash = info.chromium_npm_hash;
   };

+  # needed for header generation in electron 35 and above
+  env.ELECTRON_OUT_DIR = "Release";
+
   src = null;

   patches =

(though this would rebuild all versions, so we should probably only do this conditionally)

TomaSajt · 2025-03-09T14:53:37Z

I highly doubt lib.optionals is what we want, that's for lists.
Maybe just if cond then val else null is the easiest?
Not sure if that causes a rebuild or not.

Or perhaps lib.optionalString works?

teutat3s · 2025-03-10T21:41:33Z

Another nice surprise:

[41984/43140] ACTION //third_party/electron_node:generate_config_gypi(//build/toolchain/linux/unbundle:default)
FAILED: gen/third_party/electron_node/config.gypi
python3 ../../third_party/electron_node/tools/generate_config_gypi.py gen/third_party/electron_node/config.gypi --out-dir . --dep-file gen/third_party/electron_node/generate_config_gypi.d --node-gn-path //third_party/electron_node
Traceback (most recent call last):
  File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 113, in <module>
    main()
  File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 100, in main
    config = get_gn_config(args.out_dir)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 32, in get_gn_config
    gn_args = subprocess.check_output(
              ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/26yi95240650jxp5dj78xzch70i1kzlz-python3-3.12.9/lib/python3.12/subprocess.py", line 468, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/26yi95240650jxp5dj78xzch70i1kzlz-python3-3.12.9/lib/python3.12/subprocess.py", line 550, in run
    with Popen(*popenargs, **kwargs) as process:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/26yi95240650jxp5dj78xzch70i1kzlz-python3-3.12.9/lib/python3.12/subprocess.py", line 1028, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/nix/store/26yi95240650jxp5dj78xzch70i1kzlz-python3-3.12.9/lib/python3.12/subprocess.py", line 1963, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'gn'

TomaSajt · 2025-03-10T21:48:19Z

My main suspect upon first glance is out_dir. I encountered it when I was looking at where else ELECTRON_OUT_DIR was used. I don't have time to track it down today.

It sucks a lot that this was so late in the build process.
Perhaps we can add an extra job (like the header job) to the build so that we don't have to build everything.

Edit: --out-dir . is being passed to the python script so I might be wrong.

TomaSajt · 2025-03-11T10:23:08Z

Ideally we should be using gnChromium (an override of gn that is used to execute the listed buildTargets). Unfortunately it is not exposed directly.

IMO ideally, in the chromium/common.nix file, gnChromium should be put inside nativeBuildInputs instead of just string-iterpolating it.

teutat3s · 2025-03-11T13:32:30Z

3.5 hours later:

FAILED: gen/third_party/electron_node/config.gypi
python3 ../../third_party/electron_node/tools/generate_config_gypi.py gen/third_party/electron_node/config.gypi --out-dir . --dep-file gen/third_party/electron_node/generate_config_gypi.d --node-gn-path //third_party/electron_node
Traceback (most recent call last):
  File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 113, in <module>
    main()
  File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 100, in main
    config = get_gn_config(args.out_dir)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 32, in get_gn_config
    gn_args = subprocess.check_output(
              ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/26yi95240650jxp5dj78xzch70i1kzlz-python3-3.12.9/lib/python3.12/subprocess.py", line 468, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/26yi95240650jxp5dj78xzch70i1kzlz-python3-3.12.9/lib/python3.12/subprocess.py", line 573, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['gn', 'args', '--list', '--short', '-C', '.']' returned non-zero exit status 1.

EDIT: Trying again with the below commit.

teutat3s · 2025-03-12T22:21:16Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 387294

`x86_64-linux`

✅ 3 packages built:

electron-chromedriver_35
electron_35
electron_35-bin

teutat3s · 2025-03-13T07:37:20Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 387294

`x86_64-linux`

✅ 1 package built:

electron_34

- Changelog: https://github.com/electron/electron/releases/tag/v35.0.0 - Changelog: https://github.com/electron/electron/releases/tag/v35.0.1 - Changelog: https://github.com/electron/electron/releases/tag/v35.0.2 - Changelog: https://github.com/electron/electron/releases/tag/v35.0.3

We already set it in chromium/common.nix, see 062eb42.

electron/electron#44657 https://github.com/electron/electron/blob/e4bd0cd3dcc57cb6889f845c75952bf999cbf581/script/node/generate_node_headers.py#L34-L39 Co-authored-by: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Co-authored-by: Emily <git@emilylange.de>

because electron 35+ needs gn in PATH at build time [41984/43140] ACTION //third_party/electron_node:generate_config_gypi(//build/toolchain/linux/unbundle:default) FAILED: gen/third_party/electron_node/config.gypi python3 ../../third_party/electron_node/tools/generate_config_gypi.py gen/third_party/electron_node/config.gypi --out-dir . --dep-file gen/third_party/electron_node/generate_config_gypi.d --node-gn-path //third_party/electron_node Traceback (most recent call last): File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 113, in <module> main() File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 100, in main config = get_gn_config(args.out_dir) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 32, in get_gn_config gn_args = subprocess.check_output( ^^^^^^^^^^^^^^^^^^^^^^^^ File "/nix/store/26yi95240650jxp5dj78xzch70i1kzlz-python3-3.12.9/lib/python3.12/subprocess.py", line 468, in check_output return run(*popenargs, stdout=PIPE, timeout=timeout, check=True, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/nix/store/26yi95240650jxp5dj78xzch70i1kzlz-python3-3.12.9/lib/python3.12/subprocess.py", line 550, in run with Popen(*popenargs, **kwargs) as process: ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/nix/store/26yi95240650jxp5dj78xzch70i1kzlz-python3-3.12.9/lib/python3.12/subprocess.py", line 1028, in __init__ self._execute_child(args, executable, preexec_fn, close_fds, File "/nix/store/26yi95240650jxp5dj78xzch70i1kzlz-python3-3.12.9/lib/python3.12/subprocess.py", line 1963, in _execute_child raise child_exception_type(errno_num, err_msg, err_filename) FileNotFoundError: [Errno 2] No such file or directory: 'gn'

FAILED: gen/third_party/electron_node/config.gypi python3 ../../third_party/electron_node/tools/generate_config_gypi.py gen/third_party/electron_node/config.gypi --out-dir . --dep-file gen/third_party/electron_node/generate_config_gypi.d --node-gn-path //third_party/electron_node Traceback (most recent call last): File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 113, in <module> main() File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 105, in main f.write(repr(translate_config(args.out_dir, config, v8_config))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/build/src/out/Release/../../third_party/electron_node/tools/generate_config_gypi.py", line 62, in translate_config 'node_module_version': int(config['node_module_version']), ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ValueError: invalid literal for int() with base 10: '"133"' Co-authored-by: Ljuzig <diamond.bertelli@gmail.com>

As a precaution and to avoid problems with hydra builds that had to be fixed in the past. References: ce04dc5 (NixOS#378988) and 3f514d3.

teutat3s · 2025-03-23T17:30:41Z

Bumped to 35.0.3 and fixed conflicts.

TomaSajt

LGTM

I do not really have the time to build from source, but I'm assuming it still builds.

teutat3s · 2025-03-24T14:45:42Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 387294

`x86_64-linux`

✅ 3 packages built:

electron-chromedriver_35
electron_35
electron_35-bin

TomaSajt · 2025-03-24T14:50:01Z

Thanks, I'll merge soon :)

nixpkgs-ci · 2025-03-24T15:49:46Z

Successfully created backport PR for release-24.11:

[Backport release-24.11] electron-{bin,source,chromedriver}_35: init at 35.0.3 #392749

teutat3s requested review from emilylange and yayayayaka March 5, 2025 13:42

github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 5, 2025

emilylange requested a review from liam-murphy14 March 7, 2025 11:37

emilylange added the backport release-24.11 label Mar 7, 2025

emilylange removed their request for review March 7, 2025 11:41

teutat3s force-pushed the electron-35-init branch from 09c4e8b to e54f20f Compare March 8, 2025 14:29

teutat3s requested a review from TomaSajt March 8, 2025 14:54

teutat3s changed the title ~~electron_35-bin, electron-chromedriver_35: init at 35.0.0~~ electron_35-{bin,source}, electron-chromedriver_35: init at 35.0.0 Mar 8, 2025

teutat3s changed the title ~~electron_35-{bin,source}, electron-chromedriver_35: init at 35.0.0~~ electron-{bin,source,chromedriver}_35: init at 35.0.0 Mar 8, 2025

teutat3s force-pushed the electron-35-init branch from b6b7378 to 77de744 Compare March 8, 2025 15:09

teutat3s requested a review from yuyuyureka March 8, 2025 15:11

teutat3s marked this pull request as draft March 8, 2025 15:46

teutat3s marked this pull request as ready for review March 9, 2025 13:53

teutat3s force-pushed the electron-35-init branch from bfc7f42 to 10e64ba Compare March 10, 2025 10:26

teutat3s changed the title ~~electron-{bin,source,chromedriver}_35: init at 35.0.0~~ electron-{bin,source,chromedriver}_35: init at 35.0.1 Mar 10, 2025

teutat3s force-pushed the electron-35-init branch from 3ea453f to 413def3 Compare March 11, 2025 13:35

nix-owners bot requested a review from networkException March 11, 2025 13:37

teutat3s force-pushed the electron-35-init branch from 89e73ca to feb166e Compare March 12, 2025 14:27

ofborg bot removed the 2.status: merge conflict label Mar 12, 2025

github-actions bot added 10.rebuild-linux: 101-500 and removed 10.rebuild-linux: 11-100 labels Mar 12, 2025

teutat3s requested review from emilylange and TomaSajt March 12, 2025 15:00

wegank added the 2.status: merge conflict label Mar 16, 2025

andersk mentioned this pull request Mar 18, 2025

zulip: 5.11.1 → 5.12.0 #390714

Open

13 tasks

teutat3s and others added 8 commits March 23, 2025 18:27

electron: remove duplicate use_qt flag

eb66169

We already set it in chromium/common.nix, see 062eb42.

electron-source: try to avoid log spam

506d38b

As a precaution and to avoid problems with hydra builds that had to be fixed in the past. References: ce04dc5 (NixOS#378988) and 3f514d3.

teutat3s force-pushed the electron-35-init branch from c761376 to 506d38b Compare March 23, 2025 17:29

teutat3s changed the title ~~electron-{bin,source,chromedriver}_35: init at 35.0.1~~ electron-{bin,source,chromedriver}_35: init at 35.0.3 Mar 23, 2025

ofborg bot removed the 2.status: merge conflict label Mar 23, 2025

TomaSajt approved these changes Mar 23, 2025

View reviewed changes

wegank added the 12.approvals: 1 label Mar 23, 2025

TomaSajt merged commit 51a47f1 into NixOS:master Mar 24, 2025
43 of 44 checks passed

nixpkgs-ci bot mentioned this pull request Mar 24, 2025

[Backport release-24.11] electron-{bin,source,chromedriver}_35: init at 35.0.3 #392749

Merged

1 task

teutat3s deleted the electron-35-init branch March 24, 2025 15:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

electron-{bin,source,chromedriver}_35: init at 35.0.3 #387294

electron-{bin,source,chromedriver}_35: init at 35.0.3 #387294

teutat3s commented Mar 5, 2025 •

edited

Loading

emilylange commented Mar 7, 2025

teutat3s commented Mar 8, 2025 •

edited

Loading

TomaSajt commented Mar 8, 2025

teutat3s commented Mar 8, 2025 •

edited

Loading

TomaSajt commented Mar 8, 2025 •

edited

Loading

TomaSajt commented Mar 8, 2025

TomaSajt commented Mar 9, 2025 •

edited

Loading

teutat3s commented Mar 10, 2025

TomaSajt commented Mar 10, 2025 •

edited

Loading

TomaSajt commented Mar 11, 2025

teutat3s commented Mar 11, 2025 •

edited

Loading

teutat3s commented Mar 12, 2025

teutat3s commented Mar 13, 2025

teutat3s commented Mar 23, 2025

TomaSajt left a comment

teutat3s commented Mar 24, 2025

TomaSajt commented Mar 24, 2025

nixpkgs-ci bot commented Mar 24, 2025

electron-{bin,source,chromedriver}_35: init at 35.0.3 #387294

electron-{bin,source,chromedriver}_35: init at 35.0.3 #387294

Conversation

teutat3s commented Mar 5, 2025 • edited Loading

Things done

emilylange commented Mar 7, 2025

teutat3s commented Mar 8, 2025 • edited Loading

TomaSajt commented Mar 8, 2025

teutat3s commented Mar 8, 2025 • edited Loading

TomaSajt commented Mar 8, 2025 • edited Loading

TomaSajt commented Mar 8, 2025

TomaSajt commented Mar 9, 2025 • edited Loading

teutat3s commented Mar 10, 2025

TomaSajt commented Mar 10, 2025 • edited Loading

TomaSajt commented Mar 11, 2025

teutat3s commented Mar 11, 2025 • edited Loading

teutat3s commented Mar 12, 2025

nixpkgs-review result

x86_64-linux

teutat3s commented Mar 13, 2025

nixpkgs-review result

x86_64-linux

teutat3s commented Mar 23, 2025

TomaSajt left a comment

Choose a reason for hiding this comment

teutat3s commented Mar 24, 2025

nixpkgs-review result

x86_64-linux

TomaSajt commented Mar 24, 2025

nixpkgs-ci bot commented Mar 24, 2025

teutat3s commented Mar 5, 2025 •

edited

Loading

teutat3s commented Mar 8, 2025 •

edited

Loading

teutat3s commented Mar 8, 2025 •

edited

Loading

TomaSajt commented Mar 8, 2025 •

edited

Loading

TomaSajt commented Mar 9, 2025 •

edited

Loading

TomaSajt commented Mar 10, 2025 •

edited

Loading

teutat3s commented Mar 11, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`x86_64-linux`