Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-spice: 0.10.0 -> 0.12.0 #387765

Merged
merged 1 commit into from
Mar 23, 2025
Merged

Conversation

loganlinn
Copy link
Contributor

update to latest version, which now uses go 1.12.4.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

update to latest version, which now uses go 1.12.4.
@NickCao
Copy link
Member

NickCao commented Mar 7, 2025

Test is failing on darwin.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Mar 8, 2025
Copy link
Member

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

The current 0.10.0 version in nixpkgs fails to pass checks on build (due to git having updated since it was originally merged), and this update fixes it (at least on x86 linux)

I think it's worth merging this to fix that

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Mar 22, 2025
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 387765


x86_64-linux

✅ 1 package built:
  • git-spice

Since git-spice is broken on master, I'll merge regardless of Darwin status.

@FliegendeWurst FliegendeWurst merged commit 6a95107 into NixOS:master Mar 23, 2025
31 checks passed
@FliegendeWurst FliegendeWurst added the 8.has: package (update) This PR updates a package to a newer version label Mar 23, 2025
@vinnymeller
Copy link
Contributor

i forgot to comment but at the time i couldn't reproduce the error locally on aarch64-darwin, will take another look

@loganlinn loganlinn deleted the git-spice-0_12_0 branch March 24, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants