Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdisk: Modernise, fix build, 0.9 -> 0.10 #388480

Merged
merged 3 commits into from
Mar 22, 2025
Merged

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Mar 9, 2025

  • Modernisations:

    • Switch to finalAttrs
    • Don't use pname in src args
    • src.rev -> src.tag
    • Use --replace-fail
    • Enable strictDeps
    • Drop meta-wide with lib
    • Add meta.mainProgram
    • Migrate to pkgs/by-name
  • Added patch is from someone's AUR pdisk package fork: https://aur.archlinux.org/packages/pdisk#comment-975817
    Since there's no stability guarantee here, copied the patch into the tree.

  • Yes, src.hash of version 0.10 is the same as 0.9. No, that's not an error.
    Apple's import of pdisk-10.tar.gz into the repo seems to have produced no changes to any of the tracked files: apple-oss-distributions/pdisk@01f7971

    Making this a bump anyway, just to get the version increase of the way.

Darwin build is untested, should be tested to make sure removing the deprecated inheriting from darwin.apple_sdk.frameworks didn't break anything.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

OPNA2608 added 3 commits March 9, 2025 18:34
- Switch to finalAttrs
- Don't use pname in src args
- src.rev -> src.tag
- Use --replace-fail
- Enable strictDeps
- Drop meta-wide "with lib"
- Add meta.mainProgram
- Migrate to pkgs/by-name
Yes, src.hash is the same. No, that's not an error.
Apple's import of pdisk-10.tar.gz into the repo seems to have produced no changes to any of the tracked files.

Making this a bump anyway, just to get the version increase of the way.
@petrzjunior
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 388480

Logs: https://github.com/petrzjunior/nixpkgs-review-gha/actions/runs/13753695217


x86_64-linux

✅ 1 package built:
  • pdisk

aarch64-linux

✅ 1 package built:
  • pdisk

x86_64-darwin

✅ 1 package built:
  • pdisk

aarch64-darwin

✅ 1 package built:
  • pdisk

@OPNA2608 OPNA2608 merged commit f537f87 into NixOS:master Mar 22, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants