pdisk: Modernise, fix build, 0.9 -> 0.10 #388480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernisations:
finalAttrs
pname
insrc
argssrc.rev
->src.tag
--replace-fail
strictDeps
with lib
meta.mainProgram
Added patch is from someone's AUR pdisk package fork: https://aur.archlinux.org/packages/pdisk#comment-975817
Since there's no stability guarantee here, copied the patch into the tree.
Yes,
src.hash
of version0.10
is the same as0.9
. No, that's not an error.Apple's import of
pdisk-10.tar.gz
into the repo seems to have produced no changes to any of the tracked files: apple-oss-distributions/pdisk@01f7971Making this a bump anyway, just to get the version increase of the way.
Darwin build is untested, should be tested to make sure removing the deprecated inheriting from
darwin.apple_sdk.frameworks
didn't break anything.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.