Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doing: 1.0.10pre -> 2.1.88 #388509

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Conversation

antonmosich
Copy link
Contributor

Fixes #359264. Updating process was changing the Gemfile content and then running the updateScript. I successfully ran the binary, but didn't further test whether it's running correctly.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Fixes #359264. Updating process was changing the Gemfile as in
https://nixos.org/manual/nixpkgs/unstable/#packaging-applications and
then running the updateScript.Fixes #359264. Updating process was changing the Gemfile as in
https://nixos.org/manual/nixpkgs/unstable/#packaging-applications and
then running the updateScript.

Fixes NixOS#359264. Updating process was changing the Gemfile as in
https://nixos.org/manual/nixpkgs/unstable/#packaging-applications and
then running the updateScript.
@antonmosich
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 388509


x86_64-linux

✅ 1 package built:
  • doing

@SuperSandro2000 SuperSandro2000 merged commit b727e46 into NixOS:master Mar 21, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: doing 1.0.10pre2.1.85
2 participants