Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reaper-sws-extension: init at 2.14.0.3 #388529

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

pancaek
Copy link
Contributor

@pancaek pancaek commented Mar 9, 2025

Following up on the work done in #285832, I've gone ahead and picked up maintainership.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pancaek
Copy link
Contributor Author

pancaek commented Mar 9, 2025

I'd love help from any folks on Darwin to fix that ranlib issue we're hitting, I'm not familiar with Darwin stuff at all.

@pancaek pancaek requested a review from FliegendeWurst March 11, 2025 03:16
@FliegendeWurst
Copy link
Member

It builds successfully. As I'm not familiar with Reaper I can't test it.

results/reaper-sws-extension-x86_64-linux/
├── Scripts
│   ├── sws_python64.py
│   └── sws_python.py
└── UserPlugins
    └── reaper_sws-x86_64.so

@FliegendeWurst
Copy link
Member

The Darwin error suggests it doesn't like Apple SDK 11.3, for some reason

@pancaek
Copy link
Contributor Author

pancaek commented Mar 12, 2025

Thanks for the review! I'll poke at this a bit with other sdks, otherwise I'll probably have Darwin fetch prebuilt ones for now like I do in #383221

@pancaek pancaek force-pushed the reaper-sws-extension branch 8 times, most recently from 2eec664 to 30d0184 Compare March 19, 2025 00:03
@pancaek pancaek force-pushed the reaper-sws-extension branch from 30d0184 to def2874 Compare March 19, 2025 00:21
@FliegendeWurst FliegendeWurst merged commit b5f08e7 into NixOS:master Mar 19, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants