Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmountains: 2.10 -> 2.11 #388563

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Conversation

Sigmanificient
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@bengsparks
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 388563


x86_64-linux

✅ 1 package built:
  • xmountains

aarch64-linux

✅ 1 package built:
  • xmountains

x86_64-darwin

✅ 1 package built:
  • xmountains

aarch64-darwin

✅ 1 package built:
  • xmountains

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2298

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 16, 2025
@Sigmanificient Sigmanificient force-pushed the xmountains branch 2 times, most recently from 56c5fdc to eef9bfe Compare March 17, 2025 19:38
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 17, 2025
@wolfgangwalther
Copy link
Contributor

Can anything to fix this be done upstream? The last release from July 2024 fixed something for "gcc requirements", so I would expect upstream to be welcoming a fix?

@Sigmanificient
Copy link
Member Author

@wolfgangwalther Someone has already done it, so let me update to the latest commit directly

@Sigmanificient Sigmanificient changed the title xmountains: fix build, refactor, 2.10 -> 2.11 xmountains: 2.10 -> 2.11-unstable-2024-07-17 Mar 20, 2025
@Sigmanificient Sigmanificient changed the title xmountains: 2.10 -> 2.11-unstable-2024-07-17 xmountains: 2.10 -> 2.11 Mar 20, 2025
@bengsparks
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 388563


x86_64-linux

✅ 1 package built:
  • xmountains

aarch64-linux

✅ 1 package built:
  • xmountains

x86_64-darwin

✅ 1 package built:
  • xmountains

aarch64-darwin

✅ 1 package built:
  • xmountains

@wolfgangwalther wolfgangwalther merged commit a69781f into NixOS:master Mar 20, 2025
31 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants