Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iozone: 3.506 -> 3.507 #388653

Merged
merged 1 commit into from
Mar 20, 2025
Merged

iozone: 3.506 -> 3.507 #388653

merged 1 commit into from
Mar 20, 2025

Conversation

brookst
Copy link
Contributor

@brookst brookst commented Mar 10, 2025

iozone was failing to build on my NixOS 25.05.20250307.36fd87b (Warbler) system.
Hopefully it's ok to combine a bugfix and version bump but I can separate if necessary.

The issue was that libbif.c was building without HAVE_ANSIC_C defined and was therefore not compliant C.
The error thrown was libbif.c:205:1: error: return type defaults to 'int'.
This seems to have been allowed somehow on older systems (NixOS 24.11.715344.48913d8f9127 (Vicuna) compiles successfully).
The reason for the missing flag is that the makefile doesn't explicitly define rules for all of the object files. They do get built in a rule but with enableParallelBuilding = true, make uses implicit built-in rules for the c files. I've disabled parallel building so that the implicit rules are never evaluated since the object files already exist before they are attempted. I've left a quick explanation in a comment for anyone wanting to re-enable this in future.

The new version fixes a typo with HAVE_ANSIC_C but that doesn't meaningfully change compilation. Two new options are added to the fileop utility:

     -n        Fill files with non-compressible data.
     -L        Leave files behind.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsbot
Copy link

pbsbot commented Mar 20, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 388653


x86_64-linux

✅ 1 package built:
  • iozone

@pbsds pbsds merged commit 3051bb6 into NixOS:master Mar 20, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants