Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iozone was failing to build on my NixOS 25.05.20250307.36fd87b (Warbler) system.
Hopefully it's ok to combine a bugfix and version bump but I can separate if necessary.
The issue was that libbif.c was building without
HAVE_ANSIC_C
defined and was therefore not compliant C.The error thrown was
libbif.c:205:1: error: return type defaults to 'int'
.This seems to have been allowed somehow on older systems (NixOS 24.11.715344.48913d8f9127 (Vicuna) compiles successfully).
The reason for the missing flag is that the
makefile
doesn't explicitly define rules for all of the object files. They do get built in a rule but withenableParallelBuilding = true
,make
uses implicit built-in rules for the c files. I've disabled parallel building so that the implicit rules are never evaluated since the object files already exist before they are attempted. I've left a quick explanation in a comment for anyone wanting to re-enable this in future.The new version fixes a typo with
HAVE_ANSIC_C
but that doesn't meaningfully change compilation. Two new options are added to thefileop
utility:Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.