Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

penpot-desktop: 0.10.0 -> 0.11.0 #388752

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

NTBBloodbath
Copy link
Contributor

Update to 0.11.0.

Also removes the electron version patch as it is not required anymore, and fixes a typo in the metadata homepage link.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 12, 2025
@JohnRTitor
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 388752

Logs: https://github.com/JohnRTitor/nixpkgs-review-gha/actions/runs/13892809577


x86_64-linux

✅ 1 package built:
  • penpot-desktop

aarch64-linux

✅ 1 package built:
  • penpot-desktop

x86_64-darwin

❌ 1 package failed to build:
  • penpot-desktop

aarch64-darwin

❌ 1 package failed to build:
  • penpot-desktop

@JohnRTitor
Copy link
Contributor

Please mark it broken on darwin, if can't be fixed.

@NTBBloodbath
Copy link
Contributor Author

Please mark it broken on darwin, if can't be fixed.

Hi, my apologies for the late reply!

I honestly have no idea how Nix binaries work on macOS or how integrated they are with the system, so I deliberately didn't add support for darwin. How could I mark the package that way?

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Mar 19, 2025
@JohnRTitor JohnRTitor merged commit 3210c8b into NixOS:master Mar 19, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants