microsoft-edge: fix aad sync #388981
Merged
microsoft-edge: fix aad sync #388981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds additional deps and SSL cert file required for AAD accounts to sync properly
github-actions
bot
added
10.rebuild-darwin: 0
NixOSInfra
added
the
12. first-time contribution
isabelroses
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 388981
x86_64-linux
✅ 1 package built:
- microsoft-edge
isabelroses
added
the
12.approvals: 1
rhysmdnz
approved these changes
Mar 14, 2025
rhysmdnz
added
12.approvals: 2
|
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional dependencies and links the SSL cert file required for AAD accounts to sync properly.
Fixes #343401
The overlay mentioned in #343401 by @nta includes more deps, but in my testing only
libsecretandcacertare required to fix this functionalityThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.