Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopls: build modernize and gofix binaries #388985

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

katexochen
Copy link
Contributor

@katexochen katexochen commented Mar 11, 2025

modernize was recently introduced in v0.18.0, see https://github.com/golang/tools/releases/tag/gopls%2Fv0.18.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000
Copy link
Member

gotools is the correct package for those https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/go/gotools/package.nix

@katexochen
Copy link
Contributor Author

gotools is the correct package for those https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/go/gotools/package.nix

gopls is a separate Go module, these tools can't be built as part of gotools.

Signed-off-by: Paul Meyer <katexochen0@gmail.com>
@katexochen
Copy link
Contributor Author

@SuperSandro2000 you reacted with confused emoji, not sure how to interpret that. 😅

Do you still think this belongs into the gotools package? If so, how should I solve the problem with gopls being another module with a different set of dependencies?

@SuperSandro2000
Copy link
Member

Yep, I am confused 😂

I totally missed that those tools are in https://github.com/golang/tools/tree/master/gopls/internal I thought they where in https://github.com/golang/tools/tree/master/internal . You are totally right 😂 Sorry for creating the confusion and bouncing this. Should be good to go.

@Mic92 Mic92 merged commit beb00e7 into NixOS:master Mar 24, 2025
27 checks passed
@katexochen katexochen deleted the gopls/modernize branch March 24, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants