etterna: init at 0.74.3 #389089
Merged
etterna: init at 0.74.3 #389089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
github-actions
bot
added
10.rebuild-darwin: 0
alikindsys
force-pushed
the
init-etterna
branch
5 times, most recently
from
a869709 to
24a0e22
Compare
alikindsys
force-pushed
the
init-etterna
branch
3 times, most recently
from
f0f3250 to
fdeee9f
Compare
alikindsys
force-pushed
the
init-etterna
branch
from
fdeee9f to
61967de
Compare
FliegendeWurst
approved these changes
Mar 14, 2025
wegank
added
the
12.approvals: 1
alikindsys
force-pushed
the
init-etterna
branch
from
61967de to
f41cf2c
Compare
wegank
removed
the
12.approvals: 1
|
Bumping this since this should have two approvals, but since I rebased the tag got removed. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages
etterna. Fixes #352639 and supercedes #353956.Differences from the existing PR.
Based on the original build script and only has the external dependencies which are needed for building it. Etterna bundles most of its dependencies and statically links them so I decided not to mess much with it.
Includes a fix for the bundle downloading feature of the game which I may decide to upstream in the future.
As far as I'm concerned that patch shouldn't affect anything else.
Includes a
desktopEntryfor easy of launching.It's ready for review
This is a based on a stable release, unlike #353956 which was made before etternagame/etterna#1282 was merged and never updated since. That fix has landed on at least two stable releases (afaik) and the original PR author hasn't replied for a month which made me create this pull request.
Any feedback on how to make this package definition is highly appreciated since this is my first contribution to nixpkgs.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.