Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yubikey-manager: 5.5.1 -> 5.6.1 #389257

Merged
merged 1 commit into from
Mar 23, 2025

Conversation

afh
Copy link
Member

@afh afh commented Mar 12, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pinpox
Copy link
Member

pinpox commented Mar 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 389257


x86_64-linux

✅ 7 packages built:
  • gen-oath-safe
  • yubikey-manager
  • yubikey-manager-qt
  • yubikey-manager.dist
  • yubioath-flutter
  • yubioath-flutter.debug
  • yubioath-flutter.pubcache

@pinpox
Copy link
Member

pinpox commented Mar 12, 2025

I get a lot of these errors, when trying to run ykman-gui, not sure though if it is related to the update:

qml: qrc:/qml/YubiKey.qml:208: TypeError: Cannot read property 'success' of undefined
"PyOtherSide error: Traceback (most recent call last):\n\n  File \"<string>\", line 1, in <module>\n\nNameError: name 'yubikey' is not defined\n"
qml: Function not found: 'yubikey.controller.refresh' (Traceback (most recent call last):

  File "<string>", line 1, in <module>

NameError: name 'yubikey' is not defined
)

@afh afh changed the title yubikey-manager: 5.5.1 -> 5.6.0 yubikey-manager: 5.5.1 -> 5.6.1 Mar 19, 2025
@afh
Copy link
Member Author

afh commented Mar 19, 2025

Mind retrying with the lateset changes (update to 5.6.1) to this PR, @pinpox?

@afh afh force-pushed the update-yubikey-manager branch from bff0cac to 0ce6f5e Compare March 19, 2025 11:37
@pinpox
Copy link
Member

pinpox commented Mar 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 389257


x86_64-linux

❌ 1 package failed to build:
  • yubikey-manager-qt
✅ 6 packages built:
  • gen-oath-safe
  • yubikey-manager
  • yubikey-manager.dist
  • yubioath-flutter
  • yubioath-flutter.debug
  • yubioath-flutter.pubcache

Copy link
Member

@pinpox pinpox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -qt version still fails to build

@SuperSandro2000
Copy link
Member

That error was fixed in #372205

@SuperSandro2000 SuperSandro2000 merged commit 4fe36a1 into NixOS:master Mar 23, 2025
27 checks passed
@afh
Copy link
Member Author

afh commented Mar 23, 2025

Thanks for the additional context and for merging, @SuperSandro2000, much appreciated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants