fake-gcs-server: disable checks #389286
Merged
fake-gcs-server: disable checks #389286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commiterate
force-pushed
the
fix/fake-gcs-server
branch
2 times, most recently
from
f4120d9 to
58fa468
Compare
|
@jpetrucciani Any concerns with disabling the checks? |
|
I think that should be fine, there are many packages inside nixpkgs that do the same at the moment |
jpetrucciani
approved these changes
Mar 19, 2025
commiterate
added
12.approvals: 1
commiterate
force-pushed
the
fix/fake-gcs-server
branch
from
58fa468 to
b77b7e0
Compare
|
Comment added. |
|
GaetanLepage
approved these changes
Mar 19, 2025
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fake-gcs-serverunit tests are a bit flaky depending on the system they're built on. They worked fine on my local x86-64 NixOS and AArch64 Darwin machines, but they failed in Hydra and on some people's Ubuntu 22.04 systems.aarch64-linux: https://hydra.nixos.org/build/292290692x86_64-linux: https://hydra.nixos.org/build/291797205Errors seem to be something going wrong with server instantiation in unit tests (not sure if it's socket binding or something that's disallowed).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.