Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdbook: 0.4.45 -> 0.4.47 #389360

Merged
merged 1 commit into from
Mar 20, 2025
Merged

mdbook: 0.4.45 -> 0.4.47 #389360

merged 1 commit into from
Mar 20, 2025

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Mar 12, 2025 •
edited
Loading

Changes:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested review from matthiasbeyer and Frostman March 12, 2025 21:24
@Frostman
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 389360 --package mdbook

aarch64-darwin

✅ 1 package built:
  • mdbook

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Mar 12, 2025
@trofi
Copy link
Contributor Author

trofi commented Mar 13, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 389360

x86_64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools
❌ 5 packages failed to build:
  • nixStatic
  • nixStatic.dev
  • nixStatic.doc
  • nixStatic.man
  • zon2nix
✅ 267 packages built:
  • aba
  • appvm
  • attic-client
  • attic-server
  • bower2nix
  • bundix
  • cabal2nix
  • cached-nix-shell
  • cachix (cachix.bin, cachix.doc)
  • catppuccin-cursors
  • catppuccin-cursors.frappeBlue
  • catppuccin-cursors.frappeDark
  • catppuccin-cursors.frappeFlamingo
  • catppuccin-cursors.frappeGreen
  • catppuccin-cursors.frappeLavender
  • catppuccin-cursors.frappeLight
  • catppuccin-cursors.frappeMaroon
  • catppuccin-cursors.frappeMauve
  • catppuccin-cursors.frappePeach
  • catppuccin-cursors.frappePink
  • catppuccin-cursors.frappeRed
  • catppuccin-cursors.frappeRosewater
  • catppuccin-cursors.frappeSapphire
  • catppuccin-cursors.frappeSky
  • catppuccin-cursors.frappeTeal
  • catppuccin-cursors.frappeYellow
  • catppuccin-cursors.latteBlue
  • catppuccin-cursors.latteDark
  • catppuccin-cursors.latteFlamingo
  • catppuccin-cursors.latteGreen
  • catppuccin-cursors.latteLavender
  • catppuccin-cursors.latteLight
  • catppuccin-cursors.latteMaroon
  • catppuccin-cursors.latteMauve
  • catppuccin-cursors.lattePeach
  • catppuccin-cursors.lattePink
  • catppuccin-cursors.latteRed
  • catppuccin-cursors.latteRosewater
  • catppuccin-cursors.latteSapphire
  • catppuccin-cursors.latteSky
  • catppuccin-cursors.latteTeal
  • catppuccin-cursors.latteYellow
  • catppuccin-cursors.macchiatoBlue
  • catppuccin-cursors.macchiatoDark
  • catppuccin-cursors.macchiatoFlamingo
  • catppuccin-cursors.macchiatoGreen
  • catppuccin-cursors.macchiatoLavender
  • catppuccin-cursors.macchiatoLight
  • catppuccin-cursors.macchiatoMaroon
  • catppuccin-cursors.macchiatoMauve
  • catppuccin-cursors.macchiatoPeach
  • catppuccin-cursors.macchiatoPink
  • catppuccin-cursors.macchiatoRed
  • catppuccin-cursors.macchiatoRosewater
  • catppuccin-cursors.macchiatoSapphire
  • catppuccin-cursors.macchiatoSky
  • catppuccin-cursors.macchiatoTeal
  • catppuccin-cursors.macchiatoYellow
  • catppuccin-cursors.mochaBlue
  • catppuccin-cursors.mochaDark
  • catppuccin-cursors.mochaFlamingo
  • catppuccin-cursors.mochaGreen
  • catppuccin-cursors.mochaLavender
  • catppuccin-cursors.mochaLight
  • catppuccin-cursors.mochaMaroon
  • catppuccin-cursors.mochaMauve
  • catppuccin-cursors.mochaPeach
  • catppuccin-cursors.mochaPink
  • catppuccin-cursors.mochaRed
  • catppuccin-cursors.mochaRosewater
  • catppuccin-cursors.mochaSapphire
  • catppuccin-cursors.mochaSky
  • catppuccin-cursors.mochaTeal
  • catppuccin-cursors.mochaYellow
  • catppuccin-sddm
  • celeste
  • chirpstack-concentratord
  • colmena
  • common-updater-scripts
  • cosmic-applets
  • cosmic-applibrary
  • cosmic-bg
  • cosmic-design-demo
  • cosmic-edit
  • cosmic-ext-calculator
  • cosmic-ext-tweaks
  • cosmic-files
  • cosmic-greeter
  • cosmic-icons
  • cosmic-idle
  • cosmic-launcher
  • cosmic-notifications
  • cosmic-osd
  • cosmic-panel
  • cosmic-player
  • cosmic-randr
  • cosmic-screenshot
  • cosmic-session
  • cosmic-settings
  • cosmic-store
  • cosmic-term
  • crate2nix
  • crystal2nix
  • devenv
  • disko
  • dogdns
  • dogdns.man
  • dub-to-nix
  • dydisnix
  • find-billy
  • forecast
  • fusionInventory
  • gcalcli
  • gcalcli.dist
  • git-unroll
  • glpi-agent
  • hci
  • hercules-ci-agent
  • home-manager
  • hydra
  • hydra.doc
  • just
  • just.doc
  • just.man
  • kabeljau
  • kcl
  • libcosmicAppHook
  • libnixxml
  • lix
  • lix.debug
  • lix.dev
  • lix.devdoc
  • lix.doc
  • lix.man
  • lixVersions.lix_2_90
  • lixVersions.lix_2_90.debug
  • lixVersions.lix_2_90.dev
  • lixVersions.lix_2_90.devdoc
  • lixVersions.lix_2_90.doc
  • lixVersions.lix_2_90.man
  • lua51Packages.luarocks-nix
  • lua52Packages.luarocks-nix
  • lua53Packages.luarocks-nix
  • lua54Packages.luarocks-nix
  • luajitPackages.luarocks-nix
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • mdbook
  • mdbook-cmdrun
  • nil
  • nim_lk
  • niv (niv.bin, niv.data)
  • nix (nixVersions.nix_2_24)
  • nix-binary-cache
  • nix-bundle
  • nix-direnv
  • nix-du
  • nix-eval-jobs
  • nix-fast-build
  • nix-fast-build.dist
  • nix-forecast
  • nix-heuristic-gc
  • nix-heuristic-gc.dist
  • nix-index
  • nix-init
  • nix-inspect
  • nix-pin
  • nix-plugin-pijul
  • nix-plugins
  • nix-prefetch
  • nix-prefetch-bzr
  • nix-prefetch-cvs
  • nix-prefetch-docker
  • nix-prefetch-git
  • nix-prefetch-hg
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-required-mounts
  • nix-required-mounts.dist
  • nix-serve
  • nix-serve-ng
  • nix-template
  • nix-unit
  • nix-update
  • nix-update-source
  • nix-update-source.dist
  • nix-update.dist
  • nix-visualize
  • nix-visualize.dist
  • nix-web
  • nix.debug (nixVersions.nix_2_24.debug)
  • nix.dev (nixVersions.nix_2_24.dev)
  • nix.doc (nixVersions.nix_2_24.doc)
  • nix.man (nixVersions.nix_2_24.man)
  • nixVersions.git
  • nixVersions.git.debug
  • nixVersions.git.dev
  • nixVersions.git.doc
  • nixVersions.git.man
  • nixVersions.latest
  • nixVersions.latest.debug
  • nixVersions.latest.dev
  • nixVersions.latest.doc
  • nixVersions.latest.man
  • nixVersions.nix_2_26
  • nixVersions.nix_2_26.dev
  • nixVersions.nix_2_26.doc
  • nixVersions.nix_2_26.man
  • nixci
  • nixd
  • nixos-anywhere
  • nixos-generators
  • nixos-option
  • nixos-rebuild
  • nixos-rebuild-ng
  • nixos-rebuild-ng.dist
  • nixos-shell
  • nixpkgs-hammering
  • nixpkgs-manual
  • nixpkgs-review
  • nixpkgs-review.dist
  • nixt
  • nixt.dev
  • nixtract
  • node2nix
  • npins
  • nps
  • nuget-to-json
  • nuget-to-nix
  • nurl
  • nvfetcher
  • oboete
  • onagre
  • outline
  • pop-launcher
  • prefetch-yarn-deps
  • python312Packages.nix-kernel
  • python312Packages.nix-kernel.dist
  • python312Packages.nixpkgs-updaters-library
  • python312Packages.nixpkgs-updaters-library.dist
  • python313Packages.nix-kernel
  • python313Packages.nix-kernel.dist
  • python313Packages.nixpkgs-updaters-library
  • python313Packages.nixpkgs-updaters-library.dist
  • ragenix
  • rofi-games
  • sbomnix
  • sbomnix.dist
  • sonarr
  • ssh-openpgp-auth
  • sshd-openpgp-auth
  • swiftPackages.swiftpm2nix
  • tasks
  • terranix
  • typescript-language-server
  • update-nix-fetchgit
  • update-python-libraries
  • vimPlugins.typescript-tools-nvim
  • vimPluginsUpdater
  • vulnix
  • vulnix.dist
  • vulnix.doc
  • vulnix.man
  • wp4nix
  • xdg-desktop-portal-cosmic
  • xdg-desktop-portal-cosmic.debug
  • yarn2nix

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Mar 13, 2025
@matthiasbeyer
Copy link
Contributor

What about the failed builds?

@trofi
Copy link
Contributor Author

trofi commented Mar 19, 2025

All 2 are pre-existing failures on master:

Both are broken since Dec 2024.

@matthiasbeyer
Copy link
Contributor

Lets go then!

@matthiasbeyer matthiasbeyer merged commit fd936de into NixOS:master Mar 20, 2025
46 checks passed
@trofi trofi deleted the mdbook-update branch March 20, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frostman Frostman

@matthiasbeyer matthiasbeyer

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trofi @Frostman @matthiasbeyer @wegank