Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.thelounge-*: drop #389425

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Conversation

dotlambda
Copy link
Member

Any of those packages should be repackaged using buildNpmPackage if they are still needed.
See #229475.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nodejs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 13, 2025
Any of those packages should be repackaged using buildNpmPackage if they are still needed.
@dotlambda dotlambda force-pushed the nodePackages.thelounge branch from 6d814c5 to 4d78d19 Compare March 14, 2025 18:40
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 14, 2025
@nix-owners nix-owners bot requested a review from Luflosi March 14, 2025 18:48
@dotlambda dotlambda force-pushed the nodePackages.thelounge branch from 4d78d19 to 6b788b8 Compare March 14, 2025 19:32
@dotlambda dotlambda merged commit ed760cd into NixOS:master Mar 18, 2025
27 checks passed
@dotlambda dotlambda deleted the nodePackages.thelounge branch March 18, 2025 20:03
@dotlambda
Copy link
Member Author

dotlambda commented Mar 24, 2025

Oops, this seems to have broken postcss-cli:

trying https://registry.npmjs.org/@esbuild/linux-x64/-/linux-x64-0.25.1.tgz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 4246k  100 4246k    0     0  3381k      0  0:00:01  0:00:01 --:--:-- 3380k
error: hash mismatch in fixed-output derivation '/nix/store/5pf4yg3grgzwqcjf0s1gy8lf9zh7qjdl-linux-x64-0.25.1.tgz.drv':
        likely URL: https://registry.npmjs.org/@esbuild/linux-x64/-/linux-x64-0.25.1.tgz
         specified: sha512-9yl91rHw/cpwMCNytUDxwj2XjFpxML0y9HAOH9pNVQDpQrBxHy01Dx+vaMu0N1CKa/RzBD2hB4u//nfc+Sd3Cw==
            got:    sha512-xbfUhu/gnvSEg+EGovRc+kjBAkrvtk38RlerAzQxvMzlB4fXpCFCeUAYzJvrnhFtdeyVCDANSjJvOvGYoeKzFA==
error: 1 dependencies of derivation '/nix/store/ypcyrc6mxydrzd95v09bifxdy7zqnp6d-postcss-cli-11.0.1.drv' failed to build

This hash is defined in pkgs/development/node-packages/overrides.nix.
@natsukium introduced it in #317229.
Please repackage using buildNpmPackage if postcss-cli is still needed: #229475
Otherwise I suggest we remove the package since even if I fixed it, it would break again with the next run of pkgs/development/node-packages/generate.sh.
cc @rileyinman who added the package in #68171
cc @Luflosi who is listed as maintainer

@dotlambda dotlambda mentioned this pull request Mar 24, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants