Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/wakapi: harden systemd service #389534

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Conversation

isabelroses
Copy link
Member

@isabelroses isabelroses commented Mar 13, 2025

When using systemd-analyze security wakapi.service we went from a 5.9 to a 3.

Not sure what else can be removed.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

when using `systemd-analyze security wakapi.service` we went from a 5.9
to a 3.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 13, 2025
@isabelroses isabelroses requested a review from NotAShelf March 14, 2025 23:56
@NotAShelf
Copy link
Member

I have a feeeling that ProtectSystemset to full might break a few things. Please allow me a day to test it. Assuming you already ran the machine test for Wakapi?

@isabelroses
Copy link
Member Author

Assuming you already ran the machine test for Wakapi?

I have. Also been running these changes on my own server. Seems to work fine.

Copy link
Member

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working as per my testing. LGTM.

@NotAShelf NotAShelf added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 17, 2025
@SuperSandro2000 SuperSandro2000 merged commit 9f2544d into NixOS:master Mar 20, 2025
37 checks passed
@isabelroses isabelroses deleted the wakapi branch March 20, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants