Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amtterm: allow compiling with gamt #389575

Merged
merged 1 commit into from
Mar 20, 2025
Merged

amtterm: allow compiling with gamt #389575

merged 1 commit into from
Mar 20, 2025

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Mar 13, 2025

This adds a graphical version of amtterm, called gamt, which automatically gets built if gtk/gdk and vte are discovered.

It's gated behind a withGamt flag, defaulting to false, and available as gamt.

This follows the same logic as qcam.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 13, 2025
@flokli flokli requested a review from Kranzes March 14, 2025 07:39
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 16, 2025
This adds a graphical version of amtterm, called `gamt`, which
automatically gets built if gtk/gdk and vte are discovered.

It's gated behind a `withGamt` flag, defaulting to false, and available
as `gamt`.

This follows the same logic as qcam.
@flokli
Copy link
Contributor Author

flokli commented Mar 20, 2025

Rebased to fix the merge conflict.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2025
@flokli flokli merged commit f909097 into NixOS:master Mar 20, 2025
27 checks passed
@flokli flokli deleted the gamt branch March 20, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants