slepc: init at 3.22.2 #389678
Merged
slepc: init at 3.22.2 #389678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCao
reviewed
Mar 13, 2025
NickCao
reviewed
Mar 13, 2025
NickCao
reviewed
Mar 13, 2025
NickCao
reviewed
Mar 13, 2025
qbisi
force-pushed
the
slepc
branch
5 times, most recently
from
991274c to
b2311b5
Compare
github-actions
bot
added
10.rebuild-darwin: 11-100
and removed
10.rebuild-darwin: 1-10
labels
qbisi
force-pushed
the
slepc
branch
2 times, most recently
from
af832da to
846d6d0
Compare
doronbehar
reviewed
Mar 16, 2025
Petsc examples take up 58M and can be found in source code. Thus we do not ship petsc with examples by default.
shebang in configure script is auto patched
qbisi
force-pushed
the
slepc
branch
7 times, most recently
from
71ec4ad to
b5a2ce0
Compare
doronbehar
reviewed
Mar 18, 2025
pkgs/by-name/sl/slepc/package.nix
Outdated
| "bfort = '${sowing}/bin/bfort'" | ||
| ''; | ||
|
|
||
| # The environment variable SLEPC_DIR should be set to the build directory. |
There was a problem hiding this comment.
Don't simply say in human language what is written in Bash, explain why you write things.
Suggested change
| # The environment variable SLEPC_DIR should be set to the build directory. | |
| # Usually this project is being built as part of a `petsc` build or as part of | |
| # other projects, e.g when `petsc` is `./configure`d with | |
| # `--download-slepc=1`. This instructs the slepc to be built as a standalone | |
| # project. |
| ]; | ||
| platforms = lib.platforms.unix; | ||
| maintainers = with lib.maintainers; [ qbisi ]; | ||
| broken = stdenv.hostPlatform.isDarwin && withArpack; |
There was a problem hiding this comment.
If you have it available, it'd be nice to get a small quote from the build error. Alternatively, perhaps upstream is aware of this incompatibility, and would have liked to be notified? A comment of any kind is desired here.
There was a problem hiding this comment.
Segmentation error in mpi test for darwin platform, no idea how to fix this, but i will put the error message here.
pythonSupport is more commonly used in toPythonModule
The `withFullDeps` flag was used to make petsc4py meet the requirements of downstream projects like Fenics and Firedrake. However, this flag breaks the build on other platforms if any external packages of PETSc fail. Therefore, I disabled this flag in petsc4py and made PETSc bundle some commonly used external packages by default. Users can still have a minimally featured PETSc by setting `withCommonDeps = false`.
This substitueInplace was an old patch and will fail if use --replace-fail.
This patch does not fix the shebang at the begining of the example_template.py file. It only replaces the shebang in the template string of that file.
|
|
|
doronbehar
approved these changes
Mar 18, 2025
|
Thanks for your reivew, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scalable Library for Eigenvalue Problem Computations
Sci-lib depends on petsc and used by many math softwares.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.