Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-mockery: 2.52.1 -> 2.53.2, terragrunt: 0.75.10 -> 0.76.1 #389836

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Mar 14, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@atkrad
Copy link
Member

atkrad commented Mar 17, 2025

Hello, Is there any update?

Copy link
Contributor

@cideM cideM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel like it's my call to stand in the way of fixing a package. I only have what is ultimately a minor question about the usage of go_1_24, which can be resolved after merging this.

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Mar 17, 2025
@r-vdp
Copy link
Contributor

r-vdp commented Mar 18, 2025

It seems that unstable is already at 1.24, isn't it? So what's the purpose of the version pin here? I would prefer to unpin and then just merge. Any objections?

@06kellyjac
Copy link
Member Author

06kellyjac commented Mar 18, 2025

The objections to unpinning have already been raised.

I'll rehash the reasoning again, pulling from an existing PR with it pinned, identifying the package as being version sensitive, being exactly the same.

#390700 has been merged and now this PR needs rebasing

IMO we should be able to get build fixing PRs into unstable in less than 4 days, let alone master

@06kellyjac 06kellyjac changed the title go-mockery: 2.52.1 -> 2.53.2, terragrunt: 0.73.15 -> 0.75.9 go-mockery: 2.52.1 -> 2.53.2, terragrunt: 0.75.10 -> 0.76.1 Mar 18, 2025
@Mic92
Copy link
Member

Mic92 commented Mar 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 389836


aarch64-darwin

✅ 3 packages built:
  • git-team
  • go-mockery
  • terragrunt

@Mic92 Mic92 merged commit 671bc10 into NixOS:master Mar 18, 2025
40 of 43 checks passed
@06kellyjac 06kellyjac deleted the terragrunt branch March 18, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terragrunt: failed to upgrade
7 participants