-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go-mockery: 2.52.1 -> 2.53.2, terragrunt: 0.75.10 -> 0.76.1 #389836
Conversation
Hello, Is there any update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel like it's my call to stand in the way of fixing a package. I only have what is ultimately a minor question about the usage of go_1_24
, which can be resolved after merging this.
It seems that unstable is already at 1.24, isn't it? So what's the purpose of the version pin here? I would prefer to unpin and then just merge. Any objections? |
The objections to unpinning have already been raised. I'll rehash the reasoning again, pulling from an existing PR with it pinned, identifying the package as being version sensitive, being exactly the same. #390700 has been merged and now this PR needs rebasing IMO we should be able to get build fixing PRs into unstable in less than 4 days, let alone master |
|
Things done
also adopts latest go to work with projects using latest gonix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.