python312Packages.rtslib: 2.2.0 -> 2.2.2 #389871

r-ryantm · 2025-03-14T16:52:08Z

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for python312Packages.rtslib is: Python object API for managing the Linux LIO kernel target

meta.homepage for python312Packages.rtslib is: https://github.com/open-iscsi/rtslib-fb

Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Impact

Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.2.2 with grep in /nix/store/lfkspdvcl8z3n6h8pf9hjhnn3ibgk2ps-python3.12-rtslib-2.2.2
found 2.2.2 in filename of file in /nix/store/lfkspdvcl8z3n6h8pf9hjhnn3ibgk2ps-python3.12-rtslib-2.2.2

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

python312Packages.rtslib
python313Packages.rtslib
targetcli

Instructions to test this update (click to expand)

Either download from the cache:

nix-store -r /nix/store/lfkspdvcl8z3n6h8pf9hjhnn3ibgk2ps-python3.12-rtslib-2.2.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python312Packages.rtslib https://github.com/r-ryantm/nixpkgs/archive/52ab453dd53272b6623459bfb3e742d49c7f211d.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/52ab453dd53272b6623459bfb3e742d49c7f211d#python312Packages.rtslib

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/lfkspdvcl8z3n6h8pf9hjhnn3ibgk2ps-python3.12-rtslib-2.2.2
ls -la /nix/store/lfkspdvcl8z3n6h8pf9hjhnn3ibgk2ps-python3.12-rtslib-2.2.2/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review

`x86_64-linux`

✅ 6 packages built:

python312Packages.rtslib
python312Packages.rtslib.dist
python313Packages.rtslib
python313Packages.rtslib.dist
targetcli
targetcli.dist

Maintainer pings

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a 👍 reaction to pull requests you find important.

Defelo · 2025-03-14T18:33:09Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 389871

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/13863041888

Download packages from cache:

x86_64-linux

nix-store -r --add-root nixpkgs-pr-389871-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/lfkspdvcl8z3n6h8pf9hjhnn3ibgk2ps-python3.12-rtslib-2.2.2 \
  /nix/store/2pzyn4srqfccnnngddy79bbgfmkzf9wi-python3.12-rtslib-2.2.2-dist \
  /nix/store/b0488m51xvvhl87yzy495pnqvxl24v48-python3.13-rtslib-2.2.2 \
  /nix/store/3nn259s6igv6zgzg08fgnnyc6hhy5r6q-python3.13-rtslib-2.2.2-dist \
  /nix/store/wfs3izrwhh23wdq8v7d72y42wp7zw66v-targetcli-2.1.58 \
  /nix/store/b7j4a06gaffp5gmygh32qh497j0r6k7d-targetcli-2.1.58-dist

aarch64-linux

nix-store -r --add-root nixpkgs-pr-389871-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/gacxc9jh4r8kf8h00mbhmsnr8j103rdd-python3.12-rtslib-2.2.2 \
  /nix/store/dal4kph93lasbyb7hpmgnx0lzxd83sck-python3.12-rtslib-2.2.2-dist \
  /nix/store/zgza5vcgl45xf8h4ymmhgy9piybj6wys-python3.13-rtslib-2.2.2 \
  /nix/store/51gdgdr6rmp1byqv2n3r5hsjy7ls5dxp-python3.13-rtslib-2.2.2-dist \
  /nix/store/s15mjmi3dxzfk7mjgnps0y78psbakxpb-targetcli-2.1.58 \
  /nix/store/iwhkppjv15zvc9yj1fxa841by76pd52l-targetcli-2.1.58-dist

`x86_64-linux`

✅ 6 packages built:

python312Packages.rtslib
python312Packages.rtslib.dist
python313Packages.rtslib
python313Packages.rtslib.dist
targetcli
targetcli.dist

`aarch64-linux`

✅ 6 packages built:

python312Packages.rtslib
python312Packages.rtslib.dist
python313Packages.rtslib
python313Packages.rtslib.dist
targetcli
targetcli.dist

Defelo

Approved automatically following the successful run of nixpkgs-review.

GaetanLepage · 2025-03-14T19:03:38Z

The package has been renamed to rtslib-fb, we should operate this rename too.
(Including adding an entry in python-aliases.nix.

Defelo · 2025-03-14T21:13:48Z

@GaetanLepage I created a pr for this at #389906, you should have received a review request

GaetanLepage · 2025-03-14T22:29:57Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 389871

`x86_64-linux`

⏩ 2 packages blacklisted:

nixos-install-tools
tests.nixos-functions.nixos-test

✅ 6 packages built:

python312Packages.rtslib-fb
python312Packages.rtslib-fb.dist
python313Packages.rtslib-fb
python313Packages.rtslib-fb.dist
targetcli-fb
targetcli-fb.dist

`aarch64-linux`

⏩ 2 packages blacklisted:

nixos-install-tools
tests.nixos-functions.nixos-test

✅ 6 packages built:

python312Packages.rtslib-fb
python312Packages.rtslib-fb.dist
python313Packages.rtslib-fb
python313Packages.rtslib-fb.dist
targetcli-fb
targetcli-fb.dist

pkgs/by-name/ta/targetcli-fb/package.nix

pkgs/development/python-modules/rtslib-fb/default.nix

NickCao · 2025-03-14T23:53:41Z

@ofborg test iscsi-root iscsi-multipath-root

GaetanLepage · 2025-03-15T00:25:49Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 389871

`x86_64-linux`

⏩ 1 package blacklisted:

nixos-install-tools

✅ 13 packages built:

nvmet-cli
nvmet-cli.dist
python312Packages.configshell-fb
python312Packages.configshell-fb.dist
python312Packages.rtslib-fb
python312Packages.rtslib-fb.dist
python313Packages.configshell-fb
python313Packages.configshell-fb.dist
python313Packages.rtslib-fb
python313Packages.rtslib-fb.dist
spdk
targetcli-fb
targetcli-fb.dist

`aarch64-linux`

⏩ 1 package blacklisted:

nixos-install-tools

✅ 12 packages built:

nvmet-cli
nvmet-cli.dist
python312Packages.configshell-fb
python312Packages.configshell-fb.dist
python312Packages.rtslib-fb
python312Packages.rtslib-fb.dist
python313Packages.configshell-fb
python313Packages.configshell-fb.dist
python313Packages.rtslib-fb
python313Packages.rtslib-fb.dist
targetcli-fb
targetcli-fb.dist

`x86_64-darwin`

✅ 4 packages built:

python312Packages.configshell-fb
python312Packages.configshell-fb.dist
python313Packages.configshell-fb
python313Packages.configshell-fb.dist

`aarch64-darwin`

✅ 4 packages built:

python312Packages.configshell-fb
python312Packages.configshell-fb.dist
python313Packages.configshell-fb
python313Packages.configshell-fb.dist

NickCao · 2025-03-15T00:48:37Z

@ofborg test iscsi-root iscsi-multipath-root

Diff: open-iscsi/targetcli-fb@v2.1.58...v3.0.1

…xist

GaetanLepage · 2025-03-15T12:53:29Z

@ofborg test iscsi-root iscsi-multipath-root

NickCao · 2025-03-15T13:42:11Z

iscsi-root passed locally, but iscsi-multipath-root failed.

GaetanLepage · 2025-03-15T13:46:15Z

iscsi-root passed locally, but iscsi-multipath-root failed.

iscsi-multipath-root is already failing as darwin (as rtslib/bin/targetctl does not exist).
Now it fails with:

initiatorAuto # [   11.790184] iscsiadm[1002]: iscsiadm: cannot make connection to 2001:db8:1::3: Connection refused
(finished: waiting for unit iscsid.service, in 12.72 seconds)
initiatorAuto: waiting for unit iscsi.service
initiatorAuto # [   12.791980] iscsiadm[1002]: iscsiadm: cannot make connection to 2001:db8:1::3: Connection refused
initiatorAuto # [   13.792591] iscsiadm[1002]: iscsiadm: cannot make connection to 2001:db8:1::3: Connection refused
initiatorAuto # [   14.793392] iscsiadm[1002]: iscsiadm: cannot make connection to 2001:db8:1::3: Connection refused
initiatorAuto # [   15.793970] iscsiadm[1002]: iscsiadm: cannot make connection to 2001:db8:1::3: Connection refused
initiatorAuto # [   16.795276] iscsiadm[1002]: iscsiadm: cannot make connection to 2001:db8:1::3: Connection refused
initiatorAuto # [   16.796399] iscsiadm[1002]: iscsiadm: connection login retries (reopen_max) 5 exceeded
initiatorAuto # [   16.797912] iscsiadm[1002]: iscsiadm: Could not perform SendTargets discovery: iSCSI PDU timed out
initiatorAuto # [   16.799454] systemd[1]: iscsi.service: Control process exited, code=exited, status=11/n/a
initiatorAuto # [   16.800606] systemd[1]: iscsi.service: Failed with result 'exit-code'.
initiatorAuto # [   16.802064] systemd[1]: Failed to start Login and scanning of iSCSI devices.
initiatorAuto # [   16.803209] systemd[1]: iscsi.service: Consumed 8ms CPU time, 1.6M memory peak, 360B incoming IP traffic, 480B outgoing IP traffic.
initiatorAuto # [   16.805299] systemd[1]: Reached target Remote File Systems.
initiatorAuto # [   16.807615] systemd[1]: Starting Permit User Sessions...
initiatorAuto # [   16.827594] systemd[1]: Finished Permit User Sessions.
initiatorAuto # [   16.830333] systemd[1]: Started Getty on tty1.
initiatorAuto # [   16.831572] systemd[1]: Reached target Login Prompts.
initiatorAuto # [   16.832590] systemd[1]: Reached target Multi-User System.
initiatorAuto # [   16.833583] systemd[1]: Startup finished in 2.969s (kernel) + 13.861s (userspace) = 16.831s.

Technically it's not a regression, but it's not ideal.
I am not familiar at all with this software, so I'm not sure about what we should do.

NickCao · 2025-03-15T13:48:27Z

cc @ajs124 and @grahamc who created the iscsi/target module

GaetanLepage · 2025-03-21T22:38:23Z

No answer, should we go ahead and merge?

NickCao · 2025-03-21T22:40:28Z

No answer, should we go ahead and merge?

I guess so.

github-actions bot added 6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Mar 14, 2025

Defelo approved these changes Mar 14, 2025

View reviewed changes

GaetanLepage marked this pull request as draft March 14, 2025 19:05

Defelo mentioned this pull request Mar 14, 2025

python3Packages.rtslib-fb: rename from python3Packages.rtslib, 2.2.0 -> 2.2.2, refactor #389906

Closed

13 tasks

GaetanLepage force-pushed the auto-update/python312Packages.rtslib branch from 52ab453 to 1290585 Compare March 14, 2025 21:10

GaetanLepage marked this pull request as ready for review March 14, 2025 21:12

nix-owners bot requested a review from natsukium March 14, 2025 21:13

GaetanLepage force-pushed the auto-update/python312Packages.rtslib branch from 1290585 to 40f1984 Compare March 14, 2025 21:22

github-actions bot added 6.topic: nixos 8.has: module (update) labels Mar 14, 2025

GaetanLepage force-pushed the auto-update/python312Packages.rtslib branch 3 times, most recently from a7e3a92 to bbdac1d Compare March 14, 2025 22:17

GaetanLepage requested a review from NickCao March 14, 2025 22:30

NickCao reviewed Mar 14, 2025

View reviewed changes

pkgs/by-name/ta/targetcli-fb/package.nix Outdated Show resolved Hide resolved

pkgs/development/python-modules/rtslib-fb/default.nix Outdated Show resolved Hide resolved

pkgs/development/python-modules/rtslib-fb/default.nix Outdated Show resolved Hide resolved

GaetanLepage force-pushed the auto-update/python312Packages.rtslib branch from bbdac1d to 87f27cb Compare March 14, 2025 23:42

NickCao reviewed Mar 14, 2025

View reviewed changes

pkgs/development/python-modules/rtslib-fb/default.nix Outdated Show resolved Hide resolved

GaetanLepage force-pushed the auto-update/python312Packages.rtslib branch 2 times, most recently from 66842d3 to e7807f5 Compare March 14, 2025 23:46

GaetanLepage force-pushed the auto-update/python312Packages.rtslib branch 2 times, most recently from 7c18dec to 57fffd6 Compare March 15, 2025 00:23

GaetanLepage requested a review from NickCao March 15, 2025 00:31

github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 labels Mar 15, 2025

nix-owners bot requested a review from Hoverbear March 15, 2025 00:31

r-ryantm and others added 6 commits March 15, 2025 12:16

python312Packages.rtslib: 2.2.0 -> 2.2.2

e4ffd9c

python312Packages.rtslib: rename to rtslib-fb

68c06a0

targetcli: 2.1.58 -> 3.0.1

32c6c90

Diff: open-iscsi/targetcli-fb@v2.1.58...v3.0.1

python312Packages.rtslib-fb: remove meta.mainProgram as it does not e…

b6ec380

…xist

targetcli: rename to targetcli-fb

6e79d0d

python312Packages.configshell: rename to configshell-fb

988fef7

GaetanLepage force-pushed the auto-update/python312Packages.rtslib branch from 57fffd6 to 988fef7 Compare March 15, 2025 11:17

NickCao merged commit d2fcc2f into NixOS:master Mar 21, 2025
32 checks passed

r-ryantm deleted the auto-update/python312Packages.rtslib branch March 22, 2025 00:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python312Packages.rtslib: 2.2.0 -> 2.2.2 #389871

python312Packages.rtslib: 2.2.0 -> 2.2.2 #389871

r-ryantm commented Mar 14, 2025

Defelo commented Mar 14, 2025

Defelo left a comment

GaetanLepage commented Mar 14, 2025

Defelo commented Mar 14, 2025

GaetanLepage commented Mar 14, 2025

NickCao commented Mar 14, 2025

GaetanLepage commented Mar 15, 2025

NickCao commented Mar 15, 2025

GaetanLepage commented Mar 15, 2025

NickCao commented Mar 15, 2025

GaetanLepage commented Mar 15, 2025

NickCao commented Mar 15, 2025

GaetanLepage commented Mar 21, 2025

NickCao commented Mar 21, 2025

python312Packages.rtslib: 2.2.0 -> 2.2.2 #389871

python312Packages.rtslib: 2.2.0 -> 2.2.2 #389871

Conversation

r-ryantm commented Mar 14, 2025

Updates performed

To inspect upstream changes

Impact

Pre-merge build results

nixpkgs-review result

x86_64-linux

Maintainer pings

Defelo commented Mar 14, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

Defelo left a comment

Choose a reason for hiding this comment

GaetanLepage commented Mar 14, 2025

Defelo commented Mar 14, 2025

GaetanLepage commented Mar 14, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

NickCao commented Mar 14, 2025

GaetanLepage commented Mar 15, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

NickCao commented Mar 15, 2025

GaetanLepage commented Mar 15, 2025

NickCao commented Mar 15, 2025

GaetanLepage commented Mar 15, 2025

NickCao commented Mar 15, 2025

GaetanLepage commented Mar 21, 2025

NickCao commented Mar 21, 2025

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`