Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hexio: 1.0-RC1 -> 1.1, remove python2 #389883

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Conversation

bengsparks
Copy link

@bengsparks bengsparks commented Mar 14, 2025

Removes dependency on python2, wraps Python script properly with wrapPythonPrograms

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@bengsparks bengsparks changed the title hexio: 1.0-RC1 -> 1.1 hexio: 1.0-RC1 -> 1.1, remove python2 Mar 14, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 14, 2025
@bengsparks
Copy link
Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 389883


x86_64-linux

✅ 1 package built:
  • hexio

aarch64-linux

✅ 1 package built:
  • hexio

@github-actions github-actions bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 14, 2025
@bengsparks bengsparks force-pushed the hexio branch 2 times, most recently from 1588d4e to cf8b2d8 Compare March 14, 2025 22:24
@github-actions github-actions bot added 10.rebuild-linux: 1 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 14, 2025
@bengsparks
Copy link
Author

bengsparks commented Mar 20, 2025

@SuperSandro2000 feedback incorporated, PR updated 💪

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 389883


x86_64-linux

✅ 1 package built:
  • hexio

aarch64-linux

✅ 1 package built:
  • hexio

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. It seems to work fine.

@GaetanLepage GaetanLepage merged commit f44054e into NixOS:master Mar 20, 2025
23 of 27 checks passed
@bengsparks bengsparks deleted the hexio branch March 20, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants