turbo: 2.4.2 -> 2.4.5-canary.4 #389948
Merged
turbo: 2.4.2 -> 2.4.5-canary.4 #389948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes building against Rust 1.85 Diff: vercel/turborepo@v2.4.2...v2.4.5-canary.4 Changelog: https://github.com/vercel/turborepo/releases/tag/v2.4.5-canary.4
3 tasks
|
Tested with code shown in the below and application builds and runs. {pkgs, ...}: let
nixpkgs-modrinth-fix = pkgs.fetchFromGitHub {
owner = "getchoo-contrib";
repo = "nixpkgs";
rev = "45a17797406d7fe86b56cb4f76058fd1193283a5";
hash = "sha256-RAePo9CE6ZE4Z2yxDgCKvwcWQ35K7kSg10dcNucNL9k=";
};
system = pkgs.system;
pr389948 = import nixpkgs-modrinth-fix {
inherit system;
config.allowUnfree = true;
};
in {
environment.systemPackages = [
pr389948.modrinth-app
];
} |
|
LordGrimmauld
approved these changes
Mar 17, 2025
| @@ -63,20 +63,20 @@ rustPlatform.buildRustPackage rec { | |||
| updateScript = nix-update-script { | |||
| extraArgs = [ | |||
| "--version-regex" | |||
| "'v(\\d+\\.\\d+\\.\\d+)'" | |||
| "v(\\d+\\.\\d+\\.\\d+)$" | |||
There was a problem hiding this comment.
My only concern is the current selected version doesn't match this regex, so the updater bot could easily downgrade this package prior to the next stable release.
There was a problem hiding this comment.
Then we can draft it until the next major release
After all, this is only a temporary bump -- as the patches for building against Rust 2024 edition can't be easily backported
eclairevoyant
approved these changes
Mar 18, 2025
|
I tested this and it indeed fixes #389902! |
|
Eveeifyeve
approved these changes
Mar 19, 2025
Eveeifyeve
added
12.approvals: 3+
wegank
added
12.approvals: 1
getchoo
force-pushed
the
pkgs/turbo/2.4.5
branch
from
00ef7da to
39e1e1c
Compare
|
Just made the changelog link use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #389902
Diff: vercel/turborepo@v2.4.2...v2.4.5-canary.4
Changelog: https://github.com/vercel/turborepo/releases/tag/v2.4.5-canary.4
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.