Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.netbox-contract: init at 2.3.2 #390087

Merged
merged 1 commit into from
Mar 23, 2025

Conversation

felbinger
Copy link
Member

@felbinger felbinger commented Mar 15, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@felbinger
Copy link
Member Author

Plugin is working in netbox 4.2 on current unstable, don't know why linux eval fails in the ci pipeline right now

@felbinger felbinger force-pushed the init-netbox-contract branch from 50266e8 to 01d65f3 Compare March 15, 2025 12:01
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 15, 2025
@felbinger felbinger force-pushed the init-netbox-contract branch from 01d65f3 to a31eaa4 Compare March 15, 2025 13:03
@felbinger
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 390087

Logs: https://github.com/felbinger/nixpkgs-review-gha/actions/runs/13871898477


x86_64-linux

❌ 2 packages failed to build:
  • python313Packages.netbox-contract
  • python313Packages.netbox-contract.dist
✅ 2 packages built:
  • python312Packages.netbox-contract
  • python312Packages.netbox-contract.dist

aarch64-linux

❌ 2 packages failed to build:
  • python313Packages.netbox-contract
  • python313Packages.netbox-contract.dist
✅ 2 packages built:
  • python312Packages.netbox-contract
  • python312Packages.netbox-contract.dist

@felbinger felbinger force-pushed the init-netbox-contract branch 2 times, most recently from 48cdf33 to e7ca03d Compare March 15, 2025 13:18
@felbinger felbinger changed the title python3Packages.netbox-contract: init at 2.3.2 python312Packages.netbox-contract: init at 2.3.2 Mar 15, 2025
@github-actions github-actions bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels Mar 15, 2025
@felbinger felbinger force-pushed the init-netbox-contract branch from e7ca03d to a9819c3 Compare March 15, 2025 13:27
@github-actions github-actions bot added 10.rebuild-linux: 1 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 15, 2025
@felbinger
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 390087

Logs: https://github.com/felbinger/nixpkgs-review-gha/actions/runs/13871898477


x86_64-linux

✅ 2 packages built:
  • python312Packages.netbox-contract
  • python312Packages.netbox-contract.dist

aarch64-linux

✅ 2 packages built:
  • python312Packages.netbox-contract
  • python312Packages.netbox-contract.dist

@felbinger
Copy link
Member Author

felbinger commented Mar 15, 2025

Tests cannot be run, due to missing django project (netbox instance)

==================================== ERRORS ====================================
_____________ ERROR collecting netbox_contract/tests/test_views.py _____________
netbox_contract/tests/test_views.py:4: in
from django.contrib.contenttypes.models import ContentType
/nix/store/8f1vz4842azcfrap704i7qmjl6qflyk7-python3.12-django-5.1.7/lib/python3.12/site-packages/django/contrib/contenttypes/models.py:134: in
class ContentType(models.Model):
/nix/store/8f1vz4842azcfrap704i7qmjl6qflyk7-python3.12-django-5.1.7/lib/python3.12/site-packages/django/db/models/base.py:129: in new
app_config = apps.get_containing_app_config(module)
/nix/store/8f1vz4842azcfrap704i7qmjl6qflyk7-python3.12-django-5.1.7/lib/python3.12/site-packages/django/apps/registry.py:260: in get_containing_app_config
self.check_apps_ready()
/nix/store/8f1vz4842azcfrap704i7qmjl6qflyk7-python3.12-django-5.1.7/lib/python3.12/site-packages/django/apps/registry.py:137: in check_apps_ready
settings.INSTALLED_APPS
/nix/store/8f1vz4842azcfrap704i7qmjl6qflyk7-python3.12-django-5.1.7/lib/python3.12/site-packages/django/conf/init.py:81: in getattr
self._setup(name)
/nix/store/8f1vz4842azcfrap704i7qmjl6qflyk7-python3.12-django-5.1.7/lib/python3.12/site-packages/django/conf/init.py:61: in _setup
raise ImproperlyConfigured(
E django.core.exceptions.ImproperlyConfigured: Requested setting INSTALLED_APPS, but settings are not configured. You must either define the environment variable DJANGO_SETTINGS_MODULE or call settings.configure() before accessing settings.
=========================== short test summary info ============================
ERROR netbox_contract/tests/test_views.py - django.core.exceptions.ImproperlyConfigured: Requested setting INSTALLED_AP...
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!

@felbinger felbinger force-pushed the init-netbox-contract branch from a9819c3 to fc8bc10 Compare March 15, 2025 13:43
@fabaff
Copy link
Member

fabaff commented Mar 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 390087


x86_64-linux

✅ 2 packages built:
  • python312Packages.netbox-contract
  • python312Packages.netbox-contract.dist

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Follows the other netbox plugins.

@fabaff fabaff merged commit 8686603 into NixOS:master Mar 23, 2025
27 checks passed
@felbinger felbinger deleted the init-netbox-contract branch March 23, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants