Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.11] errands: 46.2.6 -> 46.2.8 #390151

Merged
merged 3 commits into from
Mar 22, 2025
Merged

[24.11] errands: 46.2.6 -> 46.2.8 #390151

merged 3 commits into from
Mar 22, 2025

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Mar 15, 2025

Manual backport of #362747 and #390105

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@luftmensch-luftmensch @getchoo
errands: 46.2.6 -> 46.2.7
6c5a566 
(cherry picked from commit 3632a79)
@luftmensch-luftmensch @getchoo
errands: 46.2.7 -> 46.2.8
0fe21cb 
(cherry picked from commit 1e324ae)
@getchoo getchoo added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Mar 15, 2025
NickCao
NickCao requested changes Mar 16, 2025
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hash mismatch on darwin.

@DaRacci
Copy link
Contributor

DaRacci commented Mar 20, 2025

the has is also missmatched on linux_x86-64 now, upstream must have replaced the release.

@getchoo getchoo marked this pull request as draft March 21, 2025 18:16
@getchoo
Copy link
Member Author

getchoo commented Mar 21, 2025

#391913

@getchoo
errands: fix src hash
d044713 
Seems upstream force pushed this tag

(cherry picked from commit fed48c3)
@getchoo getchoo marked this pull request as ready for review March 21, 2025 20:50
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Mar 21, 2025
@NickCao NickCao merged commit 91f8a90 into NixOS:release-24.11 Mar 22, 2025
40 of 41 checks passed
@getchoo getchoo deleted the backport/errands/46.2.8 branch March 22, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao

@sund3RRR sund3RRR

@luftmensch-luftmensch luftmensch-luftmensch

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@getchoo @DaRacci @NickCao @luftmensch-luftmensch @wegank