rp: init at 2.1.4 #390159
Merged
rp: init at 2.1.4 #390159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
|
haylinmoore
approved these changes
Mar 16, 2025
wegank
added
the
12.approvals: 1
matthiasbeyer
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
It is somehow a convention to order the attributes as follows:
- pname
- version
- src
- sourceRoot
- *inputs
- *Phase
- meta
But it doesn't really matter. I also annotated some stuff that I would have done differently, but doesn't really matter either.
As you already waited 4 days for your first-time-contribution, I wouldn't wait for another iteration here and go ahead and merge this.
Welcome to the community! 🎉
| cmake | ||
| ninja | ||
| ]; | ||
| buildInputs = lib.optionals (stdenv.isLinux) [ stdenv.cc.libc.static ]; |
There was a problem hiding this comment.
The parentheses here are not required AFAIK.
Suggested change
| buildInputs = lib.optionals (stdenv.isLinux) [ stdenv.cc.libc.static ]; | |
| buildInputs = lib.optionals stdenv.isLinux [ stdenv.cc.libc.static ]; |
Comment on lines
+26
to
+29
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| cp rp-${if stdenv.isDarwin then "osx" else "lin"} $out/bin/rp | ||
| ''; |
There was a problem hiding this comment.
This works, but I would have written it like this:
Suggested change
| installPhase = '' | |
| mkdir -p $out/bin | |
| cp rp-${if stdenv.isDarwin then "osx" else "lin"} $out/bin/rp | |
| ''; | |
| installPhase = let | |
| binname = if stdenv.isDarwin | |
| then "rp-osx" | |
| else "rp-lin"; | |
| in '' | |
| mkdir -p $out/bin | |
| cp ${binname} $out/bin/rp | |
| ''; |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/0vercl0k/rp
Changelog: https://github.com/0vercl0k/rp/releases/tag/v2.1.4
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.