Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.11] spotifyd: 0.3.5-unstable-2024-12-27 -> 0.4.0 #390160

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Mar 15, 2025

Manual backport of #387652

Tested with a Spotify Premium account

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@getchoo
Copy link
Member Author

getchoo commented Mar 17, 2025

Waiting on #390785 to be merged in master

@wolfgangwalther
Copy link
Contributor

Waiting on #390785 to be merged in master

Will you pick that in this PR, too?

@getchoo
Copy link
Member Author

getchoo commented Mar 23, 2025

Will you pick that in this PR, too?

Yep, just forgot. Thanks!

@getchoo getchoo marked this pull request as ready for review March 23, 2025 21:54
@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 390160


x86_64-linux

✅ 1 package built:
  • spotifyd

aarch64-linux

✅ 1 package built:
  • spotifyd

x86_64-darwin

✅ 1 package built:
  • spotifyd

aarch64-darwin

✅ 1 package built:
  • spotifyd

@wolfgangwalther wolfgangwalther merged commit a33389a into NixOS:release-24.11 Mar 24, 2025
38 of 40 checks passed
@getchoo getchoo deleted the backport-387652-to-release-24.11 branch March 24, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants