-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discord: add option to enable autoscrolling #390166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Thanks for your first PR.
I added a comment, let me know if you need some help.
Moving this PR to draft, feel free to remove it from draft when you think it is ready to be reviewed again.
@@ -211,7 +209,9 @@ stdenv.mkDerivation rec { | |||
|
|||
desktopItem = makeDesktopItem { | |||
name = pname; | |||
exec = binaryName; | |||
exec = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it should be done in here.
I may be wrong but if you really want to do something similar, you should wrap the binary using makeBinaryWrapper
and add the option in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right, i moved it from makeDesktopItem
to wrapProgramShell
. i hope this is better :)
Adds the option
enableAutoscroll
which enables middle-click autoscrolling.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.