python3Packages.langchain*: fix automatic updates #390196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
10.rebuild-darwin: 0
drupol
approved these changes
Mar 15, 2025
GaetanLepage
approved these changes
Mar 16, 2025
wegank
added
the
12.approvals: 2
If so, I'll have to finish up the alternate updater. The default |
|
Would it be better to keep in the |
I think so. |
sarahec
force-pushed
the
langchain-rm-updateScript
branch
from
3122386 to
60f6375
Compare
|
I'm trying explicitly supplying If it fails, we need to look upstream to either the python updater or the generic update script (the latter seems very unlikely). |
sarahec
changed the title
versionRegex to updateScript per module
sarahec
removed
the
12.approvals: 2
|
@drupol and @GaetanLepage Since I changed the updates across the board, I'm requesting a new review. |
sarahec
force-pushed
the
langchain-rm-updateScript
branch
from
60f6375 to
b834065
Compare
|
I found a reproducible test case for the bad updates and verified this fix works. Assume One more fix to do: I need to relax the dependency on |
sarahec
force-pushed
the
langchain-rm-updateScript
branch
from
b834065 to
7058e8d
Compare
sarahec
force-pushed
the
langchain-rm-updateScript
branch
from
7058e8d to
9d42854
Compare
github-actions
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 0
sarahec
changed the title
versionRegex to updateScript per module
|
|
|
sarahec
force-pushed
the
langchain-rm-updateScript
branch
from
863e6fd to
d65349c
Compare
|
sarahec
force-pushed
the
langchain-rm-updateScript
branch
from
d65349c to
1d51451
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;dr: The bulk updater kept updating each component to the wrong tag. It turns out each package needs to specify its version regex indepedently.
langchain is a monorepo that uses tags such as
langchain-sdk==0.1.2for its components. Unfortunately, the generic updater chooses the latest tag without looking at the tag expression in the fetcher.passthru.skipBulkUpdates = truewas intended to disable auto updates, but r-ryantm keept issuing piecemeal updates which updated the each component to the wrong tag (newest tag overwrote all).This PR adds an explicit
--versionRegexvalue to the update script per module. It also re-enables bulk updates as the per-component regex solves the problem.P.S. Apologies for the long comment thread. I originally approached this from a different direction that didn't work out.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.