-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dolphin-emu[-primehack]: cleanup, move to by-name #390208
Conversation
a93ee64
to
18a9c5a
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The move-to-by-name commit drops a bunch of darwin inputs, including moltenvk
which i assume is critical.
The title of 18a9c5a confuses me, please elaborate
18a9c5a
to
98eac7c
Compare
You are right. All the other ones are now provided automatically by
I changed this commit and added the dependencies back. Now they are only added to |
98eac7c
to
5b79208
Compare
|
|
5b79208
to
51d4d13
Compare
|
51d4d13
to
5fe07e6
Compare
@pbsds any additional request? |
I assume @Madouura is inactive, |
Things done
--> To be reviewed commit by commit <--
cc @pbsds, @Madouura
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.