Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.11] default-crate-overrides: proc-macro-crate: fix build for 3.3.0 #390222

Merged
merged 2 commits into from
Mar 19, 2025
Merged

[Backport release-24.11] default-crate-overrides: proc-macro-crate: fix build for 3.3.0 #390222

merged 2 commits into from
Mar 19, 2025

Conversation

nixpkgs-ci[bot]
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Mar 15, 2025

Bot-based backport to release-24.11, triggered by a label in #388844.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Mar 15, 2025
Merged
13 tasks
@nix-owners nix-owners bot requested review from winterqt, figsoda and zowoq March 15, 2025 21:14
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 15, 2025
@wolfgangwalther wolfgangwalther requested a review from Defelo March 18, 2025 18:27
@wolfgangwalther
Copy link
Contributor

The first commit was originally cherry-picked from somewhere else - with -x. This makes the commit message contain two commit references, and thus the "Check cherry-picks" job is failing.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 390222

@GaetanLepage GaetanLepage requested a review from niklaskorz March 19, 2025 07:23
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 19, 2025
@wolfgangwalther wolfgangwalther merged commit 1012e87 into release-24.11 Mar 19, 2025
28 of 29 checks passed
@wolfgangwalther wolfgangwalther deleted the backport-388844-to-release-24.11 branch March 19, 2025 11:29
niklaskorz
niklaskorz approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@niklaskorz niklaskorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a crate2nix codebase that indeed failed to build after updating proc-macro-crate to 3.3.0. Fixed with this PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklaskorz niklaskorz

@GaetanLepage GaetanLepage

@Defelo Defelo

@winterqt winterqt

@figsoda figsoda

@zowoq zowoq

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wolfgangwalther @GaetanLepage @niklaskorz @Defelo @wegank @SuperSandro2000