Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-stakeholder: init at 0-unstable-2025-03-15 #390236

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

awwpotato
Copy link
Contributor

@awwpotato awwpotato commented Mar 15, 2025

https://github.com/giacomo-b/rust-stakeholder

a CLI tool that generates absolutely meaningless but impressive-looking terminal output to convince everyone you're a coding genius without writing a single line of useful code.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@awwpotato awwpotato force-pushed the init-rust-stakeholder branch from 0386691 to 6d590ca Compare March 15, 2025 23:56
@Defelo
Copy link
Member

Defelo commented Mar 16, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 390236

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/13877818905

Download packages from cache:
  • x86_64-linux
    nix-store -r --add-root nixpkgs-pr-390236-x86_64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/36kpqva62qsvdrc0mdmj4wagwcjfavxs-rust-stakeholder-0-unstable-2025-03-15
  • aarch64-linux
    nix-store -r --add-root nixpkgs-pr-390236-aarch64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/4lrajjcp6qapsk7nyr7ivxs08hakcfwr-rust-stakeholder-0-unstable-2025-03-15
  • x86_64-darwin
    nix-store -r --add-root nixpkgs-pr-390236-x86_64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/1qbzgj1p91cm9bxgxzhqcyng10h5i32d-rust-stakeholder-0-unstable-2025-03-15
  • aarch64-darwin
    nix-store -r --add-root nixpkgs-pr-390236-aarch64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/2vm674izgf0ncszcwx9xmhnhpx41w97w-rust-stakeholder-0-unstable-2025-03-15

x86_64-linux

✅ 1 package built:
  • rust-stakeholder

aarch64-linux

✅ 1 package built:
  • rust-stakeholder

x86_64-darwin

✅ 1 package built:
  • rust-stakeholder

aarch64-darwin

✅ 1 package built:
  • rust-stakeholder

Copy link
Member

@Defelo Defelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@isabelroses isabelroses added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Mar 16, 2025
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message has the wrong version (without the 0- prefix).

@awwpotato awwpotato force-pushed the init-rust-stakeholder branch from 6d590ca to 1cfb3d1 Compare March 22, 2025 21:15
@awwpotato awwpotato changed the title rust-stakeholder: init at unstable-2025-03-15 rust-stakeholder: init at 0-unstable-2025-03-15 Mar 22, 2025
@awwpotato awwpotato force-pushed the init-rust-stakeholder branch from 1cfb3d1 to 2d059f1 Compare March 22, 2025 21:20
@awwpotato awwpotato requested a review from GaetanLepage March 22, 2025 21:20
@awwpotato awwpotato force-pushed the init-rust-stakeholder branch from 2d059f1 to 8333a23 Compare March 22, 2025 21:34
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 390236


x86_64-linux

✅ 1 package built:
  • rust-stakeholder

aarch64-linux

✅ 1 package built:
  • rust-stakeholder

x86_64-darwin

✅ 1 package built:
  • rust-stakeholder

aarch64-darwin

✅ 1 package built:
  • rust-stakeholder

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Thanks

@GaetanLepage GaetanLepage merged commit 7d41df4 into NixOS:master Mar 22, 2025
58 of 59 checks passed
@awwpotato awwpotato deleted the init-rust-stakeholder branch March 23, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants