-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdl3-ttf: init at 3.2.0, maintainers: add charain #390310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple notes:
Commits: this PR should be 2 commits. One adding you to the maintainer list, one adding sdl3-ttf. They should be titled maintainers: add charain
and sdl3-ttf: init at 3.2.0
You are using github as a source. This is completely fine. It then might make sense to do nix-update-script
too, so the bot can automatically update this package.
You are using a enableTests
override. Previous SDL and SDL_ttf packages had such an override mostly because darwin kept breaking. If the tests pass on darwin, there is no need for that override field. If they are breaking on darwin, then set a default accordingly.
cmake: you are using cmake with gnu autotools backend. Might make sense to add ninja
to nativeBuildInputs.
meta: maybe consider adding pkgConfigModules
field and add pkg-config validation to passthru?
buildInputs: the darwin additional inputs look a bit funny, did you test this?
9aa7480
to
d5a42e4
Compare
At a glance this is looking significantly better already 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You seem to have hash mismatches. Also, hash
is preferred over sha256
.
fc018d8
to
0506a8e
Compare
Successfully build this on aarch64-darwin. |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to build on both aarch64-linux and x86_64-linux. Set the platforms as marcin requested, and maybe wait for someone with a darwin machine to build this. Other than that, this seems about ready.
I tested build on aarch64-darwin, it works well. |
Co-authored-by: Qiming Chu <cchuqiming@gmail.com> Co-authored-by: Anillc <i@anillc.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 390310
x86_64-linux
✅ 1 package built:
- sdl3-ttf
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.