Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxKernel.kernels.linux_lqx: sync kernel settings with upstream package #390364

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Mar 16, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: kernel The Linux kernel 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 16, 2025
@JohnRTitor
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 390364

Logs: https://github.com/JohnRTitor/nixpkgs-review-gha/actions/runs/13919934730

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@JohnRTitor
Copy link
Contributor

Welp, I thought nixpkgs-review will rebuild the kernels?

@@ -103,6 +103,9 @@ let

}
// lib.optionalAttrs (isLqx) {
# https://github.com/damentz/liquorix-package/commit/07b176edc002f2a7825ae181613e1f79a3650fd2
CMDLINE="audit=0 intel_pstate=disable amd_pstate=disable ";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CMDLINE="audit=0 intel_pstate=disable amd_pstate=disable ";
CMDLINE = "audit=0 intel_pstate=disable amd_pstate=disable ";

@thiagokokada thiagokokada force-pushed the linux-lqx-sync-settings branch 2 times, most recently from 57e2d83 to 1924ad9 Compare March 18, 2025 10:27
@github-actions github-actions bot added 10.rebuild-linux: 101-500 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 18, 2025
@nix-owners nix-owners bot requested review from JerrySM64 and AxerTheAxe March 18, 2025 10:31
@thiagokokada thiagokokada force-pushed the linux-lqx-sync-settings branch from 1924ad9 to f1dd162 Compare March 18, 2025 10:47
@thiagokokada thiagokokada merged commit 2384221 into NixOS:master Mar 18, 2025
33 of 35 checks passed
@thiagokokada thiagokokada deleted the linux-lqx-sync-settings branch March 18, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: kernel The Linux kernel 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants