Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libblake3: 1.6.1 -> 1.7.0; enable TBB multi-threading support #390458

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

silvanshade
Copy link
Member

@silvanshade silvanshade commented Mar 16, 2025

This PR updates the version to 1.7.0 and enables recent TBB multi-threading support for libblake3.

  • Built on platform(s)
    • x86_64-linux

@fgaz

Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good except for the comments I left. Also as you write let's wait for a release

@silvanshade silvanshade force-pushed the blake3-tbb branch 3 times, most recently from 005a382 to 9a2c412 Compare March 17, 2025 16:20
@silvanshade silvanshade marked this pull request as ready for review March 18, 2025 21:31
@silvanshade
Copy link
Member Author

@fgaz Release 1.7.0 is published which enables this feature.

@silvanshade
Copy link
Member Author

silvanshade commented Mar 18, 2025

One question I have about the tbb dependency: libblake3 supports at least tbb version 2021_11 but here I've opted to use the latest available in nixpkgs which is 2022_0.

However, I've noticed that version 2022_0 doesn't seem to be available yet for nix (building via the flake), where I intend to use this feature.

I suppose maybe it doesn't matter because nix would still need to update nixpkgs in order to have access to the current libblake3 (or specify a custom local package where it doesn't matter) so at that point the latest tbb should also be available.

Any thoughts on this?

@silvanshade silvanshade changed the title libblake3: enable TBB multi-threading support libblake3: 1.6.1 -> 1.7.0; enable TBB multi-threading support Mar 18, 2025
@Ericson2314 Ericson2314 merged commit fd36cd2 into NixOS:master Mar 19, 2025
58 checks passed
@Ericson2314
Copy link
Member

@silvanshade You can backport the tbb version you need to 24.11 as a new package. I think that should unblock you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants