-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
legcord: refactor; 1.1.0 -> 1.1.1 #390517
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5292 |
2675335
to
f46fc89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell with limited testing of venmic and legcord, seems to work without errors:
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 390517
x86_64-linux
✅ 1 package built:
- legcord
Actually, one change I forgot in the review, you should split up your commits if I am not mistaken:
|
f46fc89
to
4d50cf2
Compare
done :3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 390517
x86_64-linux
✅ 1 package built:
- legcord
Things done
Refactor to use
finalAttrs
Refactor to remove
with lib
usage inmeta
Update to
1.1.1
Make the
.desktop
file more accurateAdd
nyabinary
(me) as a maintainerUse
tag
instead ofrev
Fix
venmic
(thanks @wrmilling and @water-sucks); supersedes #388827nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.