Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legcord: refactor; 1.1.0 -> 1.1.1 #390517

Merged
merged 3 commits into from
Mar 22, 2025
Merged

Conversation

nyabinary
Copy link
Contributor

@nyabinary nyabinary commented Mar 16, 2025

Things done

Refactor to use finalAttrs
Refactor to remove with lib usage in meta
Update to 1.1.1
Make the .desktop file more accurate
Add nyabinary (me) as a maintainer
Use tag instead of rev
Fix venmic (thanks @wrmilling and @water-sucks); supersedes #388827

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 16, 2025
@nix-owners nix-owners bot requested review from water-sucks and wrmilling March 16, 2025 22:52
@water-sucks
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.
Command: nixpkgs-review pr 390517

x86_64-linux

✅ 1 package built:
  • legcord

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5292

Copy link
Member

@wrmilling wrmilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell with limited testing of venmic and legcord, seems to work without errors:

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 390517


x86_64-linux

✅ 1 package built:
  • legcord

@wrmilling
Copy link
Member

Actually, one change I forgot in the review, you should split up your commits if I am not mistaken:

  • legcord: 1.1.0 -> 1.1.1
  • legcord: refactor
  • legcord: add nyabinary as maintainer

@nyabinary
Copy link
Contributor Author

Actually, one change I forgot in the review, you should split up your commits if I am not mistaken:

* legcord: 1.1.0 -> 1.1.1

* legcord: refactor

* legcord: add nyabinary as maintainer

done :3

Copy link
Member

@water-sucks water-sucks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.
Command: nixpkgs-review pr 390517

x86_64-linux

✅ 1 package built:
  • legcord

@water-sucks water-sucks added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Mar 21, 2025
@khaneliman khaneliman merged commit 66fa3e2 into NixOS:master Mar 22, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants