jbigkit: fix darwin compile and link #390602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
approved these changes
Mar 17, 2025
Emin017
force-pushed
the
fix-jbigkit-darwin
branch
from
4d64277 to
a82f1d3
Compare
drupol
approved these changes
Mar 17, 2025
Emin017
force-pushed
the
fix-jbigkit-darwin
branch
from
a82f1d3 to
ec65b16
Compare
Merged
6 tasks
toonn
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
Not a very thorough review but I didn't notice any serious problems.
I do know that non-platform dependent patches are usually preferred but I know it's painful with .so v. .dylib (note that the extension is pretty much just cosmetic, Darwin is fine with .so).
wegank
added
the
12.approvals: 1
Emin017
force-pushed
the
fix-jbigkit-darwin
branch
from
ec65b16 to
d6c19f5
Compare
drupol
approved these changes
Mar 18, 2025
|
|
Emin017
force-pushed
the
fix-jbigkit-darwin
branch
from
d6c19f5 to
273a5ce
Compare
|
I appologize for I made a mistake in deleting some of the linked libraries, which caused issues with using this package as a shared library on Darwin. This has been resolved in the new commit that has been pushed. |
wegank
removed
the
12.approvals: 1
|
|
It seems that the remaining failed packages and tests have been failed to be built on hydra for a long time. |
|
Why's this not a problem with homebrew? https://github.com/Homebrew/homebrew-core/blob/4cd5165d5645d6cc0c7e10f543c2bceddfd44b32/Formula/j/jbigkit.rb |
Emin017
force-pushed
the
fix-jbigkit-darwin
branch
from
273a5ce to
c706fae
Compare
I'm sorry, I got caught up in the patches and didn't realize that these patches were not needed for the Darwin platform. I have fixed this in the new commit that I have pushed. |
Emin017
force-pushed
the
fix-jbigkit-darwin
branch
from
c706fae to
25ad606
Compare
|
Emin017
force-pushed
the
fix-jbigkit-darwin
branch
from
25ad606 to
30da2de
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
13 tasks
drupol
reviewed
Mar 21, 2025
Emin017
force-pushed
the
fix-jbigkit-darwin
branch
from
30da2de to
440ca91
Compare
|
|
Could you adjust your commit log message to reflect what has been done within this PR ? Current:
|
Emin017
force-pushed
the
fix-jbigkit-darwin
branch
from
440ca91 to
3ba8419
Compare
Emin017
changed the title
|
|
amarshall
reviewed
Mar 21, 2025
Emin017
force-pushed
the
fix-jbigkit-darwin
branch
from
3ba8419 to
687f08a
Compare
drupol
requested changes
Mar 21, 2025
Apply patches to linux platforms only, which are not required for darwin platforms. Signed-off-by: Qiming Chu <cchuqiming@gmail.com>
Emin017
force-pushed
the
fix-jbigkit-darwin
branch
from
687f08a to
c486c6f
Compare
drupol
approved these changes
Mar 21, 2025
wegank
added
the
12.approvals: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply patches to linux platforms only, which are not required for darwin platforms.
Fix #345659
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.