Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pnpm_{8,9,10}: add updateScript; pnpm_10: 10.6.3 -> 10.6.5 #390687

Merged
merged 2 commits into from
Mar 22, 2025
Merged

pnpm_{8,9,10}: add updateScript; pnpm_10: 10.6.3 -> 10.6.5 #390687

merged 2 commits into from
Mar 22, 2025
+28 −3

Conversation

Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Mar 17, 2025 •
edited
Loading

https://github.com/pnpm/pnpm/releases/tag/v10.6.5

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from gepbird March 17, 2025 14:24
@Scrumplex Scrumplex force-pushed the pkgs/pnpm_10/bump-2025-03-001 branch from 3f9618f to cef2f05 Compare March 17, 2025 14:49
@Scrumplex Scrumplex changed the title pnpm_10: 10.6.3 -> 10.6.4 pnpm_{8,9,10}: add updateScript; pnpm_10: 10.6.3 -> 10.6.4 Mar 17, 2025
@Scrumplex Scrumplex added the backport release-24.11 Backport PR automatically label Mar 17, 2025
@Scrumplex
Copy link
Member Author

Sadly this will cause a rebuild of all packages using pnpm, as pname has changed

gepbird
gepbird suggested changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding an update script!

@gepbird
Copy link
Contributor

gepbird commented Mar 17, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 390687

aarch64-linux

✅ 9 packages built:
  • aonsoku
  • authelia
  • fedistar
  • pnpm (pnpm_10)
  • renovate
  • vencord
  • vencord-web-extension
  • webcord-vencord
  • youtube-music

(I started this before you added the update script, hence the lower rebuild number)

@Scrumplex Scrumplex force-pushed the pkgs/pnpm_10/bump-2025-03-001 branch from 416d990 to 5cace21 Compare March 19, 2025 08:32
gepbird
gepbird approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the update script for both versions, built a pnpm 8, 9 and 10 package, and previously built all pnpm 10 packages. Changes LGTM

@gepbird gepbird added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Mar 19, 2025
@Scrumplex
pnpm_{8,9,10}: add updateScript
69151f7 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex
pnpm_10: 10.6.3 -> 10.6.5
b171b54 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex Scrumplex force-pushed the pkgs/pnpm_10/bump-2025-03-001 branch from 5cace21 to b171b54 Compare March 19, 2025 20:03
@Scrumplex
Copy link
Member Author

I have removed the pname change as suggested by @SuperSandro2000. I also reverted the pure nix-shell to accommodate proxies and other impurities.

Also updated to pnpm 10.6.5

@Scrumplex Scrumplex changed the title pnpm_{8,9,10}: add updateScript; pnpm_10: 10.6.3 -> 10.6.4 pnpm_{8,9,10}: add updateScript; pnpm_10: 10.6.3 -> 10.6.5 Mar 19, 2025
@gepbird
Copy link
Contributor

gepbird commented Mar 20, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 390687

aarch64-linux

✅ 9 packages built:
  • aonsoku
  • authelia
  • fedistar
  • pnpm (pnpm_10)
  • renovate
  • vencord
  • vencord-web-extension
  • webcord-vencord
  • youtube-music

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 20, 2025
@wegank wegank merged commit 0f572ed into NixOS:master Mar 22, 2025
43 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 22, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Mar 22, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000

@gepbird gepbird

Assignees
No one assigned
Labels
6.topic: nodejs 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Scrumplex @gepbird @SuperSandro2000 @wegank