-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initrd: implement panic-on-fail interpreterless #390698
initrd: implement panic-on-fail interpreterless #390698
Conversation
48f522a
to
c88b299
Compare
For the record, there are other script-based services in systemd initrd. But yea this is a step in that direction :) I think the
We could instead do something like this maybe:
Haven't tested it, but I assume it would work. EDIT: I just realized how silly it is to worry about log spam in a service that crashes the kernel... |
Yes that's true. This one was the easiest to fix because it does not require writing a new program. I think @WilliButz is working on replacing the other |
@ElvishJerricco I think you're still raising a good point. Also your echo solution is more straight forward. I'm going add this change. |
c88b299
to
deb045e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
In order to have initrd not depend on an interpreter like bash being present.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.