mlir: emit libMLIR.so for not-static host platforms #390756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: llvm/clang
nix-owners
bot
requested review from
Ericson2314,
dtzWill,
rrbutani,
lovek323,
alyssais,
sternenseemann and
RossComputerGuy
|
RossComputerGuy
approved these changes
Mar 18, 2025
|
This looks like it would fix #389430 |
3 tasks
wegank
added
12.approvals: 1
alyssais
reviewed
Mar 19, 2025
| @@ -61,6 +61,8 @@ stdenv.mkDerivation rec { | |||
| "-DLLVM_ENABLE_DUMP=ON" | |||
| "-DLLVM_TABLEGEN_EXE=${buildLlvmTools.tblgen}/bin/llvm-tblgen" | |||
| "-DMLIR_TABLEGEN_EXE=${buildLlvmTools.tblgen}/bin/mlir-tblgen" | |||
| ] ++ lib.optionals (!stdenv.hostPlatform.isStatic) [ | |||
| "-DLLVM_BUILD_LLVM_DYLIB=ON" | |||
There was a problem hiding this comment.
Usually it's better to add these unconditionally using lib.cmakeBool unless we want to leave it to the default in other cases for some reason. In this case, I think we'd always want the dylib on non-static platforms, and never want it on static.
There was a problem hiding this comment.
Ack, made this unconditional with lib.cmakeBool
mlir piggybacks onto LLVM_BUILD_LLVM_DYLIB for determining if a
shared libMLIR.so is emitted. This also fixes build failures
in MLIR 20+ where tablegen'd files aren't generated.
In file included from /build/mlir-src-21.0.0-unstable-2025-03-09/mlir/include/mlir/IR/UseDefLists.h:16,
from /build/mlir-src-21.0.0-unstable-2025-03-09/mlir/include/mlir/IR/Value.h:17,
from /build/mlir-src-21.0.0-unstable-2025-03-09/mlir/include/mlir/IR/BlockSupport.h:16,
from /build/mlir-src-21.0.0-unstable-2025-03-09/mlir/include/mlir/IR/OperationSupport.h:18,
from /build/mlir-src-21.0.0-unstable-2025-03-09/mlir/include/mlir/IR/Dialect.h:17,
from /build/mlir-src-21.0.0-unstable-2025-03-09/mlir/tools/mlir-lsp-server/mlir-lsp-server.cpp:9:
/build/mlir-src-21.0.0-unstable-2025-03-09/mlir/include/mlir/IR/Location.h:145:10: fatal error: mlir/IR/BuiltinLocationAttributes.h.inc: No such file or directory
145 | #include "mlir/IR/BuiltinLocationAttributes.h.inc"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
picostove
force-pushed
the
mlir-emit-dylib
branch
from
eae11d7 to
e3f1e70
Compare
alyssais
approved these changes
Mar 21, 2025
wegank
added
12.approvals: 2
13 tasks
|
I think we're good to merge here, I'll merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mlir piggybacks onto
LLVM_BUILD_LLVM_DYLIBfor determining if a sharedlibMLIR.sois emitted. This also fixes build failures in MLIR 20+ where tablegen'd files aren't generated.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.