Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amdgpu_top: 0.10.3 -> 0.10.4 #390825

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Conversation

Gliczy
Copy link
Member

@Gliczy Gliczy commented Mar 18, 2025

https://github.com/Umio-Yasuno/amdgpu_top/releases/tag/v0.10.4
Umio-Yasuno/amdgpu_top@v0.10.3...v0.10.4

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Mar 18, 2025
@nix-owners nix-owners bot requested a review from geri1701 March 18, 2025 01:27
@FlorianFranzen
Copy link
Contributor

FlorianFranzen commented Mar 18, 2025

Tested binary and works well.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 390825


x86_64-linux

✅ 1 package built:
  • amdgpu_top

@Gliczy Gliczy added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Mar 18, 2025
@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 390825


x86_64-linux

✅ 1 package built:
  • amdgpu_top

aarch64-linux

✅ 1 package built:
  • amdgpu_top

@khaneliman khaneliman merged commit 8cdd95d into NixOS:master Mar 18, 2025
29 checks passed
@Gliczy Gliczy deleted the amdgpu_top-0.10.4 branch March 18, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants