-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cusparselt: init at 0.7.1 #390863
cusparselt: init at 0.7.1 #390863
Conversation
8da29b5
to
44411e3
Compare
4187127
to
b88e830
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
Thanks for tackling this one!
b88e830
to
3016de2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked that cusparselt
builds
I am trying to build torch-2.6.0 from #377785 on top of this PR using the following patch (I also tried diff --git a/pkgs/development/python-modules/torch/default.nix b/pkgs/development/python-modules/torch/default.nix
index f961705a4af59..69ce99693347b 100644
--- a/pkgs/development/python-modules/torch/default.nix
+++ b/pkgs/development/python-modules/torch/default.nix
@@ -476,6 +476,7 @@ buildPythonPackage rec {
cuda_nvml_dev # <nvml.h>
cuda_nvrtc
cuda_nvtx # -llibNVToolsExt
+ cusparselt.lib
libcublas
libcufft
libcurand
but the following error still persist:
The file does exists on my machine: $ ls /nix/store/0fxpjwfi41vrsh2qd5c30g018kdffzld-libcusparse_lt-0.7.1.0-lib/lib/
libcusparseLt.so libcusparseLt.so.0 libcusparseLt.so.0.7.1.0 However it is in @GaetanLepage do we need to patch something in |
This is a good question... @SomeoneSerge will probably know. |
Let's merge this and fix in the subsequent PR if needed. |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Addressing #270446.
Add a 👍 reaction to pull requests you find important.