Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cusparselt: init at 0.7.1 #390863

Merged
merged 3 commits into from
Mar 21, 2025
Merged

cusparselt: init at 0.7.1 #390863

merged 3 commits into from
Mar 21, 2025

Conversation

sepiabrown
Copy link
Contributor

@sepiabrown sepiabrown commented Mar 18, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Addressing #270446.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: cuda Parallel computing platform and API 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Mar 18, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 18, 2025
@sepiabrown sepiabrown changed the title cusparselt: init at 0.7.1 (#270446) cusparselt: init at 0.7.1 (NixOS#270446) Mar 18, 2025
@sepiabrown sepiabrown changed the title cusparselt: init at 0.7.1 (NixOS#270446) cusparselt: init at 0.7.1 (#270446) Mar 18, 2025
@sepiabrown sepiabrown force-pushed the cusparselt-init branch 3 times, most recently from 4187127 to b88e830 Compare March 18, 2025 06:54
@sepiabrown sepiabrown changed the title cusparselt: init at 0.7.1 (#270446) cusparselt: init at 0.7.1 Mar 18, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 390863


x86_64-linux

✅ 8 packages built:
  • cudaPackages.cusparselt (cudaPackages.cusparselt_0_7)
  • cudaPackages.cusparselt.dev (cudaPackages.cusparselt_0_7.dev)
  • cudaPackages.cusparselt.lib (cudaPackages.cusparselt_0_7.lib)
  • cudaPackages.cusparselt.static (cudaPackages.cusparselt_0_7.static)
  • cudaPackages_11.cusparselt (cudaPackages_11.cusparselt_0_7)
  • cudaPackages_11.cusparselt.dev (cudaPackages_11.cusparselt_0_7.dev)
  • cudaPackages_11.cusparselt.lib (cudaPackages_11.cusparselt_0_7.lib)
  • cudaPackages_11.cusparselt.static (cudaPackages_11.cusparselt_0_7.static)

aarch64-linux

✅ 8 packages built:
  • cudaPackages.cusparselt (cudaPackages.cusparselt_0_7)
  • cudaPackages.cusparselt.dev (cudaPackages.cusparselt_0_7.dev)
  • cudaPackages.cusparselt.lib (cudaPackages.cusparselt_0_7.lib)
  • cudaPackages.cusparselt.static (cudaPackages.cusparselt_0_7.static)
  • cudaPackages_11.cusparselt (cudaPackages_11.cusparselt_0_7)
  • cudaPackages_11.cusparselt.dev (cudaPackages_11.cusparselt_0_7.dev)
  • cudaPackages_11.cusparselt.lib (cudaPackages_11.cusparselt_0_7.lib)
  • cudaPackages_11.cusparselt.static (cudaPackages_11.cusparselt_0_7.static)

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.
Thanks for tackling this one!

Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that cusparselt builds

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 19, 2025
@prusnak
Copy link
Member

prusnak commented Mar 19, 2025

I am trying to build torch-2.6.0 from #377785 on top of this PR using the following patch (I also tried cusparselt instead of cusparselt.lib):

diff --git a/pkgs/development/python-modules/torch/default.nix b/pkgs/development/python-modules/torch/default.nix
index f961705a4af59..69ce99693347b 100644
--- a/pkgs/development/python-modules/torch/default.nix
+++ b/pkgs/development/python-modules/torch/default.nix
@@ -476,6 +476,7 @@ buildPythonPackage rec {
         cuda_nvml_dev # <nvml.h>
         cuda_nvrtc
         cuda_nvtx # -llibNVToolsExt
+        cusparselt.lib
         libcublas
         libcufft
         libcurand

but the following error still persist:

error: auto-patchelf could not satisfy dependency libcusparseLt.so.0 wanted by /nix/store/90xjhvjdbli1b0vcqcq6if9hr2qgkvpp-python3.12-torch-2.6.0/lib/python3.12/site-packages/torch/lib/libtorch_cuda.so

The file does exists on my machine:

$ ls /nix/store/0fxpjwfi41vrsh2qd5c30g018kdffzld-libcusparse_lt-0.7.1.0-lib/lib/
libcusparseLt.so  libcusparseLt.so.0  libcusparseLt.so.0.7.1.0

However it is in "${cusparselt.lib}/lib" instead of "${cusparselt.lib}/lib64", not sure if this is relevant

@GaetanLepage do we need to patch something in cusparselt (this PR) or it is something to be fixed in torch (PR #377785)?

@GaetanLepage
Copy link
Contributor

@GaetanLepage do we need to patch something in cusparselt (this PR) or it is something to be fixed in torch (PR #377785)?

This is a good question... @SomeoneSerge will probably know.

@prusnak
Copy link
Member

prusnak commented Mar 21, 2025

@GaetanLepage do we need to patch something in cusparselt (this PR) or it is something to be fixed in torch (PR #377785)?

Let's merge this and fix in the subsequent PR if needed.

@prusnak prusnak merged commit 1b9c962 into NixOS:master Mar 21, 2025
31 checks passed
@prusnak prusnak mentioned this pull request Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cuda Parallel computing platform and API 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants