Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.11] nuget-to-json: fix silent error after curl update #390936

Merged
merged 2 commits into from
Mar 18, 2025
Merged

[Backport release-24.11] nuget-to-json: fix silent error after curl update #390936

merged 2 commits into from
Mar 18, 2025

Conversation

nixpkgs-ci[bot]
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Mar 18, 2025

Bot-based backport to release-24.11, triggered by a label in #390928.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

corngood added 2 commits March 18, 2025 11:41
@corngood @github-actions
nuget-to-json: stop hiding curl errors
25feb49 
(cherry picked from commit 2afe69a)
(cherry picked from commit 5918547)
@corngood @github-actions
nuget-to-json: use --netrc-optional for curl
8153341 
Fixes: #389194
(cherry picked from commit 7a36c0e)
(cherry picked from commit 36721b0)
@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Mar 18, 2025
Merged
13 tasks
@GGG-KILLER GGG-KILLER added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Mar 18, 2025
MattSturgeon
MattSturgeon approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@MattSturgeon MattSturgeon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CI wants the commit messages to remove references to 2afe69a and 7a36c0e, as I guess these are the original commits that won't end up being merged anymore.

Probably fine either way, since github should keep those commits available for lookup even unmerged.

@GGG-KILLER
Copy link
Contributor

Looks like it isn't smart enough to pick the last commit hash in case a commit is cherry-picked multiple times. I chose to approve it anyways because I don't think that warrants blocking this PR, it's just a sanity check anyways.

@corngood corngood merged commit 6c8e4e4 into release-24.11 Mar 18, 2025
27 of 30 checks passed
@corngood corngood deleted the backport-390928-to-release-24.11 branch March 18, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattSturgeon MattSturgeon

@GGG-KILLER GGG-KILLER

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GGG-KILLER @MattSturgeon @corngood