Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yew-fmt: 0.5.5 -> 0.6 #390947

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Conversation

dandedotdev
Copy link
Contributor

@dandedotdev dandedotdev commented Mar 18, 2025

Updating the yew-fmt to the latest version 0.6.

I just tried to upgrade it this afternoon and ran into the error logs below:

       >    Compiling shrimple-parser v0.0.12
       >    Compiling syn v2.0.98
       >    Compiling dirs-sys v0.4.1
       > error: Option::<T>::expect is not yet stable as a const fn
       >   --> /build/yew-fmt-0.6-vendor/shrimple-parser-0.0.12/src/loc.rs:95:23
       >    |
       > 95 |                 line: NonZero::new(self.line.get() + rhs.line.get() - 1).expect("no overflow"),
       >    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       >
       >    Compiling dirs v5.0.1
       > error: could not compile shrimple-parser (lib) due to 1 previous error
       > warning: build failed, waiting for other jobs to finish...

The reason of this error is the versions of rustc and cargo in RustPlatform is not new enough. Hence, I specified the latest stable versions with rust-bin.

Thanks for the reviewer helping me understand that I don't need to do this.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 390947


x86_64-linux

✅ 1 package built:
  • yew-fmt

@FliegendeWurst FliegendeWurst merged commit 6b10a1f into NixOS:master Mar 20, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants